feat: add better default precision selection#471
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes first-load chart data and share-link precision semantics for users who relied on implicit FP4; logic is isolated and covered by tests but affects core global filter behavior.
Overview
Precision filters no longer always open on FP4. When the user has not explicitly chosen precisions (props,
i_prec, preset, or toggle),GlobalFilterContextnow derives effective precisions from availability curve counts via new helpers indefault-precisions.ts: prefer the densest precision when every option has enough curves (≥4), otherwise show all precisions so sparse options (e.g. MiniMax M3 FP4) are not hidden. Loaded unofficial-run precisions are merged in so overlays stay visible.A
precisionExplicitflag tracks explicit vs auto mode. Manual/setSelectedPrecisionsand URLi_precset it true; auto mode omitsi_precfrom URL sync so shared links keep following per-model defaults.url-state.tschangesPARAM_DEFAULTS.i_precfromfp4to''so an explicit FP4 choice is not stripped on reload.Unit tests cover counting, default picking, and
resolveEffectivePrecisions(explicit honor, unofficial merge, loading fallback).Reviewed by Cursor Bugbot for commit 446d8c1. Bugbot is set up for automated code reviews on this repo. Configure here.