Skip to content

[port] fix(agentic): Align changelog configs with legend / 统一 Agentic 变更记录与图例配置名称#608

Merged
cquil11 merged 1 commit into
masterfrom
cquil11/agentx-changelog-master
Jul 21, 2026
Merged

[port] fix(agentic): Align changelog configs with legend / 统一 Agentic 变更记录与图例配置名称#608
cquil11 merged 1 commit into
masterfrom
cquil11/agentx-changelog-master

Conversation

@cquil11

@cquil11 cquil11 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Port note

Ports the exact three-file patch from #603 onto master. #603 was merged only into the now-defunct feat/agentx branch and therefore was not included in the separate #604#607 port.

Summary

  • Parse Agentic changelog config keys into the same canonical hardware key used by chart points and the legend.
  • Render “Updated Configs” with the legend’s shared hardware-label builder.
  • Use the canonical key for modified-config highlighting, restoring the red legend state for Agentic configs.
  • Preserve existing fixed-sequence changelog behavior.

Root cause and impact

Agentic changelog keys append scenario metadata such as agentic-hicache after the framework. The old formatter treated those suffixes as part of the framework name, producing labels such as VLLM AGENTIC, and the highlight path failed to match the legend key.

After this change, the changelog uses the same canonical label as the legend and highlights the corresponding modified configuration correctly.

Validation

中文说明

移植说明

#603 的完整三文件补丁移植到 master#603 仅合并到了现已弃用的 feat/agentx 分支,因此未包含在另一个 #604#607 移植中。

概要

  • 将 Agentic 变更记录中的 config key 解析为图表数据点和图例共用的规范化硬件 key。
  • “Updated Configs” 改用图例的统一硬件名称生成逻辑。
  • 修改配置的红色高亮使用同一规范化 key,恢复 Agentic 配置的图例高亮。
  • 保持现有固定序列长度变更记录行为不变。

根因与影响

Agentic 变更记录的 config key 会在 framework 后附加 agentic-hicache 等场景元数据。旧 formatter 将这些后缀误当作 framework 名称的一部分,因此产生 VLLM AGENTIC 等标签,并且高亮逻辑无法匹配图例 key。

本次改动后,变更记录会使用与图例一致的规范化名称,并正确高亮对应的已修改配置。

验证


Note

Low Risk
Localized changelog/legend formatting and highlight logic with new unit tests; no auth, data, or API changes.

Overview
Agentic changelog config keys append scenario metadata (e.g. agentic-hicache) after the serving framework. The PR introduces changelogConfigToHwKey to map those keys to the same canonical hwKey the scatter chart and legend use, stripping scenario suffixes while preserving mtp when present.

Changelog UI now builds “Updated Configs” labels via getHardwareConfig / getDisplayLabel (same as the legend) instead of treating trailing tokens as framework names. configKeyMatchesHwKey delegates to the new parser, so comparison changelog GPU filtering stays consistent.

Scatter legend highlighting for modified configs switches from hyphen-suffix matching to a Set of canonical hw keys derived from changelog entries, restoring red highlight for agentic configs that previously failed to match.

Reviewed by Cursor Bugbot for commit 872f34b. Bugbot is set up for automated code reviews on this repo. Configure here.

Reuse the canonical chart hardware-key and display-label path for changelog config formatting and modified-config highlighting. Add regression coverage for agentic HiCache suffixes.

中文:统一变更记录与图例中的配置名称;复用规范化硬件 key 和显示名称逻辑,并修复 Agentic HiCache 配置的红色高亮。新增对应的回归测试。
@cquil11
cquil11 requested a review from adibarra as a code owner July 21, 2026 16:50
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
inferencemax-app Ready Ready Preview, Comment Jul 21, 2026 4:51pm

Request Review

@cquil11
cquil11 merged commit 115da5f into master Jul 21, 2026
22 of 23 checks passed
@cquil11
cquil11 deleted the cquil11/agentx-changelog-master branch July 21, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant