Skip to content

Commit 03a3975

Browse files
functionstackxfunctionstackx
authored
Revert "Move pip install to dedicated GitHub Actions steps (#206)"
This reverts commit b1df040.
1 parent 917372f commit 03a3975

7 files changed

Lines changed: 30 additions & 129 deletions

‎.github/workflows/collect-results.yml‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,6 @@ jobs:
2222
token: ${{ secrets.REPO_PAT }}
2323
fetch-depth: 0
2424

25-
- name: Set up Python
26-
uses: actions/setup-python@v6
27-
with:
28-
python-version: '3.12'
29-
30-
- name: Install dependencies
31-
run: pip install -q matplotlib
32-
3325
- name: Download JSON artifacts
3426
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
3527
with:
@@ -49,7 +41,9 @@ jobs:
4941
path: agg_${{ inputs.exp-name || 'all' }}.json
5042

5143
- name: Plot performance
52-
run: python3 utils/plot_perf.py results/ ${{ inputs.exp-name || 'all' }}
44+
run: |
45+
pip install -q matplotlib
46+
python3 utils/plot_perf.py results/ ${{ inputs.exp-name || 'all' }}
5347
- name: Upload performance graphs
5448
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
5549
with:

‎.github/workflows/e2e-tests.yml‎

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,9 @@ jobs:
1818
- name: Checkout code
1919
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
2020

21-
- name: Set up Python
22-
uses: actions/setup-python@v6
23-
with:
24-
python-version: '3.12'
25-
26-
- name: Install dependencies
27-
run: pip install pydantic pyyaml
28-
2921
- id: get-jobs
3022
run: |
23+
pip install pydantic
3124
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py ${{ inputs.generate-cli-command }})
3225
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT
3326
@@ -77,20 +70,15 @@ jobs:
7770
token: ${{ secrets.REPO_PAT }}
7871
fetch-depth: 0
7972

80-
- name: Set up Python
81-
uses: actions/setup-python@v6
82-
with:
83-
python-version: '3.12'
84-
85-
- name: Install dependencies
86-
run: pip install PyGithub
87-
8873
- name: Download results artifacts
8974
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
9075
with:
9176
path: ${{ env.RESULTS_DIR }}
9277
pattern: results_*
9378

79+
- name: Install python dependencies
80+
run: pip install PyGithub
81+
9482
- name: Calculate success rate
9583
run: python3 utils/calc_success_rate.py $STATS_FILENAME
9684

‎.github/workflows/full-sweep-1k1k-scheduler.yml‎

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,9 @@ jobs:
1414
- name: Checkout code
1515
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
1616

17-
- name: Set up Python
18-
uses: actions/setup-python@v6
19-
with:
20-
python-version: '3.12'
21-
22-
- name: Install dependencies
23-
run: pip install pydantic pyyaml
24-
2517
- id: get-dsr1-configs
2618
run: |
19+
pip install pydantic
2720
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 1k1k --model-prefix dsr1)
2821
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT
2922
@@ -35,16 +28,9 @@ jobs:
3528
- name: Checkout code
3629
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3730

38-
- name: Set up Python
39-
uses: actions/setup-python@v6
40-
with:
41-
python-version: '3.12'
42-
43-
- name: Install dependencies
44-
run: pip install pydantic pyyaml
45-
4631
- id: get-gptoss-configs
4732
run: |
33+
pip install pydantic
4834
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 1k1k --model-prefix gptoss)
4935
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT
5036
@@ -173,20 +159,15 @@ jobs:
173159
token: ${{ secrets.REPO_PAT }}
174160
fetch-depth: 0
175161

176-
- name: Set up Python
177-
uses: actions/setup-python@v6
178-
with:
179-
python-version: '3.12'
180-
181-
- name: Install dependencies
182-
run: pip install PyGithub
183-
184162
- name: Download results artifacts
185163
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
186164
with:
187165
path: ${{ env.RESULTS_DIR }}
188166
pattern: results_*
189167

168+
- name: Install python dependencies
169+
run: pip install PyGithub
170+
190171
- name: Calculate success rate
191172
run: python3 utils/calc_success_rate.py $STATS_FILENAME
192173

‎.github/workflows/full-sweep-1k8k-scheduler.yml‎

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,9 @@ jobs:
1414
- name: Checkout code
1515
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
1616

17-
- name: Set up Python
18-
uses: actions/setup-python@v6
19-
with:
20-
python-version: '3.12'
21-
22-
- name: Install dependencies
23-
run: pip install pydantic pyyaml
24-
2517
- id: get-dsr1-configs
2618
run: |
19+
pip install pydantic
2720
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 1k8k --model-prefix dsr1)
2821
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT
2922
@@ -35,16 +28,9 @@ jobs:
3528
- name: Checkout code
3629
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3730

38-
- name: Set up Python
39-
uses: actions/setup-python@v6
40-
with:
41-
python-version: '3.12'
42-
43-
- name: Install dependencies
44-
run: pip install pydantic pyyaml
45-
4631
- id: get-gptoss-configs
4732
run: |
33+
pip install pydantic
4834
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 1k8k --model-prefix gptoss)
4935
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT
5036
@@ -128,20 +114,15 @@ jobs:
128114
token: ${{ secrets.REPO_PAT }}
129115
fetch-depth: 0
130116

131-
- name: Set up Python
132-
uses: actions/setup-python@v6
133-
with:
134-
python-version: '3.12'
135-
136-
- name: Install dependencies
137-
run: pip install PyGithub
138-
139117
- name: Download results artifacts
140118
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
141119
with:
142120
path: ${{ env.RESULTS_DIR }}
143121
pattern: results_*
144122

123+
- name: Install python dependencies
124+
run: pip install PyGithub
125+
145126
- name: Calculate success rate
146127
run: python3 utils/calc_success_rate.py $STATS_FILENAME
147128

‎.github/workflows/full-sweep-8k1k-scheduler.yml‎

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,9 @@ jobs:
1414
- name: Checkout code
1515
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
1616

17-
- name: Set up Python
18-
uses: actions/setup-python@v6
19-
with:
20-
python-version: '3.12'
21-
22-
- name: Install dependencies
23-
run: pip install pydantic pyyaml
24-
2517
- id: get-dsr1-configs
2618
run: |
19+
pip install pydantic
2720
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 8k1k --model-prefix dsr1)
2821
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT
2922
@@ -35,16 +28,9 @@ jobs:
3528
- name: Checkout code
3629
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3730

38-
- name: Set up Python
39-
uses: actions/setup-python@v6
40-
with:
41-
python-version: '3.12'
42-
43-
- name: Install dependencies
44-
run: pip install pydantic pyyaml
45-
4631
- id: get-gptoss-configs
4732
run: |
33+
pip install pydantic
4834
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 8k1k --model-prefix gptoss)
4935
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT
5036
@@ -173,20 +159,15 @@ jobs:
173159
token: ${{ secrets.REPO_PAT }}
174160
fetch-depth: 0
175161

176-
- name: Set up Python
177-
uses: actions/setup-python@v6
178-
with:
179-
python-version: '3.12'
180-
181-
- name: Install dependencies
182-
run: pip install PyGithub
183-
184162
- name: Download results artifacts
185163
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
186164
with:
187165
path: ${{ env.RESULTS_DIR }}
188166
pattern: results_*
189167

168+
- name: Install python dependencies
169+
run: pip install PyGithub
170+
190171
- name: Calculate success rate
191172
run: python3 utils/calc_success_rate.py $STATS_FILENAME
192173

‎.github/workflows/full-sweep-test.yml‎

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -48,18 +48,11 @@ jobs:
4848
- name: Checkout code
4949
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
5050

51-
- name: Set up Python
52-
uses: actions/setup-python@v6
53-
with:
54-
python-version: '3.12'
55-
56-
- name: Install dependencies
57-
run: pip install pydantic pyyaml
58-
5951
# This looks complicated, but it is just calling generate_sweep_configs.py conditioned on
6052
# discrete inputs (i.e., run_1k1k, run_h100, etc.) to split the test sweep into discrete jobs
6153
- id: generate-configs
6254
run: |
55+
pip install pydantic
6356
6457
set -x
6558
# Build runner type filters based on inputs
@@ -434,20 +427,15 @@ jobs:
434427
token: ${{ secrets.REPO_PAT }}
435428
fetch-depth: 0
436429

437-
- name: Set up Python
438-
uses: actions/setup-python@v6
439-
with:
440-
python-version: '3.12'
441-
442-
- name: Install dependencies
443-
run: pip install PyGithub
444-
445430
- name: Download results artifacts
446431
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
447432
with:
448433
path: ${{ env.RESULTS_DIR }}
449434
pattern: results_*
450435

436+
- name: Install python dependencies
437+
run: pip install PyGithub
438+
451439
- name: Calculate success rate
452440
run: python3 utils/calc_success_rate.py $STATS_FILENAME
453441

‎.github/workflows/label-validation.yml‎

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,6 @@ jobs:
1818
- name: Checkout code
1919
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
2020

21-
- name: Set up Python
22-
uses: actions/setup-python@v6
23-
with:
24-
python-version: '3.12'
25-
26-
- name: Install dependencies
27-
run: pip install pydantic pyyaml
28-
2921
- id: get-jobs
3022
shell: python
3123
run: |
@@ -57,6 +49,7 @@ jobs:
5749
# Generate configs for standard labels
5850
all_configs = []
5951
if matching:
52+
subprocess.run(['pip', 'install', 'pydantic'], check=True)
6053
6154
for label in matching:
6255
result = subprocess.run([
@@ -132,20 +125,15 @@ jobs:
132125
token: ${{ secrets.REPO_PAT }}
133126
fetch-depth: 0
134127

135-
- name: Set up Python
136-
uses: actions/setup-python@v6
137-
with:
138-
python-version: '3.12'
139-
140-
- name: Install dependencies
141-
run: pip install PyGithub
142-
143128
- name: Download results artifacts
144129
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
145130
with:
146131
path: ${{ env.RESULTS_DIR }}
147132
pattern: results_*
148133

134+
- name: Install python dependencies
135+
run: pip install PyGithub
136+
149137
- name: Calculate success rate
150138
run: python3 utils/calc_success_rate.py $STATS_FILENAME
151139

0 commit comments

Comments
 (0)