Skip to content

Commit 48a220d

Browse files
committed
fix summary table hardware
1 parent ae4e481 commit 48a220d

8 files changed

Lines changed: 8 additions & 10 deletions

File tree

.github/workflows/benchmark-tmpl.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ jobs:
134134
- name: Launch job script
135135
env:
136136
RUNNER_NAME: ${{ runner.name }}
137+
RUNNER_TYPE: ${{ inputs.runner }}
137138
RESULT_FILENAME: ${{ env.EXP_NAME }}_${{ env.PRECISION }}_${{ env.FRAMEWORK }}_tp${{ env.TP }}_ep${{ env.EP_SIZE }}_dpa_${{ env.DP_ATTENTION }}_conc${{ env.CONC }}_${{ runner.name }}
138139
# Suppress per-job eval markdown from being appended to the step summary.
139140
# We'll publish a single combined eval table in the collection job instead.

runners/launch_b200-dgxc.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ docker run --rm --init --network host --name $server_name \
4141
-e HF_TOKEN -e HF_HUB_CACHE -e MODEL -e TP -e CONC -e MAX_MODEL_LEN -e ISL -e OSL -e PORT=$PORT -e EP_SIZE -e DP_ATTENTION \
4242
-e NCCL_GRAPH_REGISTER=0 \
4343
-e TORCH_CUDA_ARCH_LIST="10.0" -e CUDA_DEVICE_ORDER=PCI_BUS_ID -e CUDA_VISIBLE_DEVICES="0,1,2,3,4,5,6,7" \
44-
-e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RESULT_FILENAME -e RANDOM_RANGE_RATIO -e NUM_PROMPTS -e RUN_EVAL \
44+
-e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RESULT_FILENAME -e RANDOM_RANGE_RATIO -e NUM_PROMPTS -e RUN_EVAL -e RUNNER_TYPE \
4545
--entrypoint=/bin/bash \
4646
$(echo "$IMAGE" | sed 's/#/\//') \
4747
benchmarks/"${EXP_NAME%%_*}_${PRECISION}_b200${FRAMEWORK_SUFFIX}_docker.sh"

runners/launch_b200-nvd.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ docker run --rm --init --network host --name $server_name \
4242
-e HF_TOKEN -e HF_HUB_CACHE -e MODEL -e TP -e CONC -e MAX_MODEL_LEN -e ISL -e OSL -e PORT=$PORT -e EP_SIZE -e DP_ATTENTION \
4343
-e NCCL_GRAPH_REGISTER=0 \
4444
-e TORCH_CUDA_ARCH_LIST="10.0" -e CUDA_DEVICE_ORDER=PCI_BUS_ID -e CUDA_VISIBLE_DEVICES="0,1,2,3,4,5,6,7" \
45-
-e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RESULT_FILENAME -e RANDOM_RANGE_RATIO -e NUM_PROMPTS -e RUN_EVAL \
45+
-e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RESULT_FILENAME -e RANDOM_RANGE_RATIO -e NUM_PROMPTS -e RUN_EVAL -e RUNNER_TYPE \
4646
--entrypoint=/bin/bash \
4747
$(echo "$IMAGE" | sed 's/#/\//') \
4848
benchmarks/"${EXP_NAME%%_*}_${PRECISION}_b200${FRAMEWORK_SUFFIX}_docker.sh"

runners/launch_h100-cr.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ docker run --rm --network=host --name=$server_name \
1010
--runtime=nvidia --gpus=all --ipc=host --privileged --shm-size=16g --ulimit memlock=-1 --ulimit stack=67108864 \
1111
-v $HF_HUB_CACHE_MOUNT:$HF_HUB_CACHE \
1212
-v $GITHUB_WORKSPACE:/workspace/ -w /workspace/ \
13-
-e HF_TOKEN -e HF_HUB_CACHE -e MODEL -e TP -e CONC -e MAX_MODEL_LEN -e ISL -e OSL -e RUN_EVAL -e RESULT_FILENAME -e RANDOM_RANGE_RATIO -e PORT=$PORT \
13+
-e HF_TOKEN -e HF_HUB_CACHE -e MODEL -e TP -e CONC -e MAX_MODEL_LEN -e ISL -e OSL -e RUN_EVAL -e RUNNER_TYPE -e RESULT_FILENAME -e RANDOM_RANGE_RATIO -e PORT=$PORT \
1414
-e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e TORCH_CUDA_ARCH_LIST="9.0" -e CUDA_DEVICE_ORDER=PCI_BUS_ID -e CUDA_VISIBLE_DEVICES="0,1,2,3,4,5,6,7" \
1515
--entrypoint=/bin/bash \
1616
$IMAGE \

runners/launch_mi300x-amd.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ docker run --rm --ipc=host --shm-size=16g --network=host --name=$server_name \
1414
-v $HF_HUB_CACHE_MOUNT:$HF_HUB_CACHE \
1515
-v $GITHUB_WORKSPACE:/workspace/ -w /workspace/ \
1616
-e HF_TOKEN -e HF_HUB_CACHE -e MODEL -e TP -e CONC -e MAX_MODEL_LEN -e PORT=$PORT \
17-
-e ISL -e OSL -e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RANDOM_RANGE_RATIO -e RESULT_FILENAME -e RUN_EVAL \
17+
-e ISL -e OSL -e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RANDOM_RANGE_RATIO -e RESULT_FILENAME -e RUN_EVAL -e RUNNER_TYPE \
1818
--entrypoint=/bin/bash \
1919
$IMAGE \
2020
benchmarks/"${EXP_NAME%%_*}_${PRECISION}_mi300x_docker.sh"

runners/launch_mi300x-cr.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ docker run --rm --ipc=host --shm-size=16g --network=host --name=$server_name \
1414
-v $HF_HUB_CACHE_MOUNT:$HF_HUB_CACHE \
1515
-v $GITHUB_WORKSPACE:/workspace/ -w /workspace/ \
1616
-e HF_TOKEN -e HF_HUB_CACHE -e MODEL -e TP -e CONC -e MAX_MODEL_LEN -e PORT=$PORT \
17-
-e ISL -e OSL -e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RANDOM_RANGE_RATIO -e RESULT_FILENAME -e RUN_EVAL \
17+
-e ISL -e OSL -e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RANDOM_RANGE_RATIO -e RESULT_FILENAME -e RUN_EVAL -e RUNNER_TYPE \
1818
--entrypoint=/bin/bash \
1919
$IMAGE \
2020
benchmarks/"${EXP_NAME%%_*}_${PRECISION}_mi300x_docker.sh"

runners/launch_mi355x-amd.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ docker run --rm --ipc=host --shm-size=16g --network=host --name=$server_name \
3636
-v $HF_HUB_CACHE_MOUNT:$HF_HUB_CACHE \
3737
-v $GITHUB_WORKSPACE:/workspace/ -w /workspace/ \
3838
-e HF_TOKEN -e HF_HUB_CACHE -e MODEL -e TP -e CONC -e MAX_MODEL_LEN -e PORT=$PORT -e NUM_PROMPTS \
39-
-e ISL -e OSL -e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RANDOM_RANGE_RATIO -e RESULT_FILENAME -e RUN_EVAL \
39+
-e ISL -e OSL -e PYTHONPYCACHEPREFIX=/tmp/pycache/ -e RANDOM_RANGE_RATIO -e RESULT_FILENAME -e RUN_EVAL -e RUNNER_TYPE \
4040
--entrypoint=/bin/bash \
4141
$IMAGE \
4242
benchmarks/"${EXP_NAME%%_*}_${PRECISION}_mi355x_docker.sh"

utils/collect_eval_results.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -293,12 +293,9 @@ def main():
293293
else:
294294
continue
295295

296-
# Merge with meta
297-
# Only use explicit hardware label written to meta_env.json ('hw')
298-
hw_value = meta.get('hw', 'Unknown GPU')
299296
row = {
300297
'model': m.get('model') or meta.get('model') or 'unknown',
301-
'hw': hw_value,
298+
'hw': meta.get('hw'),
302299
'framework': (meta.get('framework') or 'unknown').lower(),
303300
'precision': (meta.get('precision') or 'unknown').lower(),
304301
'tp': int(meta.get('tp') or 1),

0 commit comments

Comments
 (0)