Skip to content

Commit 5eb8ea1

Browse files
committed
move ntasks per node to framework level instead of runner level
1 parent c95a3e4 commit 5eb8ea1

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

benchmarks/dsr1_fp4_gb200_dynamo-trt_slurm.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,11 @@ fi
3939

4040
kind=dynamo_disagg
4141
additional_slurm_args="--time=04:00:00"
42+
ntasks_per_node=4
4243

4344
gen_nodes=$(((DECODE_TP + 3)/4 * DECODE_NUM_WORKERS))
4445
total_nodes=$((PREFILL_NUM_WORKERS + gen_nodes))
45-
total_tasks=$((total_nodes * NTASKS_PER_NODE))
46+
total_tasks=$((total_nodes * ntasks_per_node))
4647

4748
decode_eplb_num_slots=0
4849

runners/launch_gb200-nv.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ set -x
88
export SLURM_PARTITION="batch"
99
export SLURM_ACCOUNT="benchmark"
1010
export SLURM_JOB_NAME="benchmark-dynamo.job"
11-
# For GB200 we have 4 GPUs per node
12-
export NTASKS_PER_NODE=4
1311

1412
# For SGLang - we are working on updating the 8k1k configs
1513
# For now we add conditionals to this script to use newer code for the 1k1k configs

0 commit comments

Comments
 (0)