Skip to content

Commit 5f5f80a

Browse files
committed
fix: use FRAMEWORK arg in collect_latest_results.py to match vllm-disagg log dirs
Signed-off-by: Theresa Shan <theresa.shan@amd.com>
1 parent ac04641 commit 5f5f80a

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

runners/launch_mi355x-amds.sh

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,16 +124,14 @@ if [[ "$IS_MULTINODE" == "true" ]]; then
124124
if [[ "${EVAL_ONLY:-false}" != "true" ]]; then
125125
cat > collect_latest_results.py <<'PY'
126126
import os, sys
127-
job_dir, isl, osl, nexp = sys.argv[1], int(sys.argv[2]), int(sys.argv[3]), int(sys.argv[4])
128-
prefixes = ["sglang", "vllm"]
127+
job_dir, isl, osl, nexp, framework = sys.argv[1], int(sys.argv[2]), int(sys.argv[3]), int(sys.argv[4]), sys.argv[5]
129128
logs_root = f"{job_dir}/logs/"
130129
candidates = []
131130
if os.path.isdir(logs_root):
132131
for name in os.listdir(logs_root):
133-
for pfx in prefixes:
134-
subdir = f"{logs_root}{name}/{pfx}_isl_{isl}_osl_{osl}"
135-
if os.path.isdir(subdir):
136-
candidates.append(subdir)
132+
subdir = f"{logs_root}{name}/{framework}_isl_{isl}_osl_{osl}"
133+
if os.path.isdir(subdir):
134+
candidates.append(subdir)
137135
for path in sorted(candidates, key=os.path.getmtime, reverse=True)[:nexp]:
138136
print(path)
139137
PY

0 commit comments

Comments
 (0)