Skip to content

Commit 632fbef

Browse files
seungrokjclaude
andcommitted
fix(agentic-mtp): clean up script to match ref, expand sweep concurrencies
Remove debug comments and 0719 markers, drop commented-out code blocks, and remove duplicate MAX_RUNNING_REQUESTS (already set upstream in script). Expand DPA sweep to full concurrency range [4,8,16,32,48,52]. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 5212545 commit 632fbef

2 files changed

Lines changed: 1 addition & 19 deletions

File tree

benchmarks/single_node/agentic/dsv4_fp4_mi355x_sglang_mtp.sh

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,6 @@ CHUNKED_PREFILL_SIZE=8192
8080
PARALLEL_ARGS=(--tensor-parallel-size "$TP")
8181
if [ "$DP_ATTENTION" = "true" ]; then
8282
USE_SGLANG_ROUTER=true
83-
# DPA + MTP needs additional runtime headroom for speculative decode and
84-
# communication buffers beyond SGLang's static KV pool.
85-
# 0719
86-
#MEM_FRACTION_STATIC=0.75
8783
export AIPERF_HTTP_X_SMG_ROUTING_KEY_FROM_CORRELATION_ID=true
8884
SGLANG_BACKEND_PORT=$((PORT + 1))
8985
SGLANG_ROUTER_METRICS_PORT=$((PORT + 10000))
@@ -93,13 +89,8 @@ if [ "$DP_ATTENTION" = "true" ]; then
9389
export SGLANG_DP_SHARED_EXPERT_LOCAL=1
9490
export SGLANG_DP_USE_GATHERV=1
9591
export SGLANG_DP_USE_REDUCE_SCATTER=1
96-
# 0719
9792
export GPU_MAX_HW_QUEUES=5
9893

99-
# SGLang divides the configured chunk across DP schedulers. Use a 16K
100-
# per-scheduler chunk so long agentic prefill tails drain within the
101-
# standard 600-second warmup grace period.
102-
# 0719
10394
CHUNKED_PREFILL_SIZE=$((8192 * TP))
10495
PARALLEL_ARGS+=(
10596
--dp "$TP"
@@ -111,13 +102,6 @@ fi
111102
if [ "$EP_SIZE" -gt 1 ]; then
112103
PARALLEL_ARGS+=(--ep-size "$EP_SIZE")
113104
fi
114-
115-
# SGLang treats max-running-requests as a global DPA limit and partitions it
116-
# internally. CUDA graph capture is per scheduler, so only its batch size is
117-
# divided across DP ranks.
118-
# 0719
119-
MAX_RUNNING_REQUESTS=$((2 * CONC))
120-
# 0719
121105
CUDA_GRAPH_MAX_BS=$CONC
122106
[ "$CUDA_GRAPH_MAX_BS" -gt 128 ] && CUDA_GRAPH_MAX_BS=128
123107

configs/amd-master.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1563,9 +1563,7 @@ dsv4-fp4-mi355x-sglang-agentic-mtp:
15631563
agentic-coding:
15641564
- dram-utilization: 0.80
15651565
search-space:
1566-
#- { tp: 8, kv-offloading: none, conc-list: [4, 8], spec-decoding: mtp }
1567-
#- { tp: 8, dp-attn: true, kv-offloading: none, conc-list: [16, 32, 48, 52], spec-decoding: mtp }
1568-
- { tp: 8, dp-attn: true, kv-offloading: none, conc-list: [48], spec-decoding: mtp }
1566+
- { tp: 8, dp-attn: true, kv-offloading: none, conc-list: [4, 8, 16, 32, 48, 52], spec-decoding: mtp }
15691567

15701568
# MiniMax-M3 MXFP8 MI355X recipe:
15711569
# https://github.com/vllm-project/recipes/commit/2a3728ed9892debfd767a72a58ebc90b33f186e5

0 commit comments

Comments
 (0)