Skip to content

Commit 84feeda

Browse files
committed
adding tests
1 parent af3b8be commit 84feeda

3 files changed

Lines changed: 26 additions & 2 deletions

File tree

.github/workflows/e2e-tests.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: End-to-End Tests
2-
run-name: e2e Test - ${{ github.event.inputs.generate-cli-command }}
2+
run-name: e2e Test - ${{ inputs.test-name || github.event.inputs.generate-cli-command }}
33

44
on:
55
workflow_dispatch:
@@ -8,6 +8,10 @@ on:
88
description: "Command passed to generate matrix script"
99
required: true
1010
type: string
11+
test-name:
12+
description: "Name for this test run"
13+
required: false
14+
type: string
1115

1216
jobs:
1317
get-jobs:

utils/matrix-logic/generate_sweep_configs.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,12 @@ def generate_runner_model_sweep_config(args, all_config_data, runner_data):
260260

261261
is_multinode = val.get(Fields.MULTINODE.value, False)
262262

263+
# Skip configs that don't match the requested node type
264+
if args.single_node and is_multinode:
265+
continue
266+
if args.multi_node and not is_multinode:
267+
continue
268+
263269
# Get model code for exp_name
264270
model_code = val[Fields.MODEL_PREFIX.value]
265271
# Get disagg value, defaulting to False if not specified
@@ -517,6 +523,18 @@ def main():
517523
required=False,
518524
help='Filter runner nodes by substring match (e.g., "mi300x-amd" to only include nodes containing that string)'
519525
)
526+
test_node_group = test_config_parser.add_mutually_exclusive_group(
527+
required=True)
528+
test_node_group.add_argument(
529+
'--single-node',
530+
action='store_true',
531+
help='Generate single-node configurations only'
532+
)
533+
test_node_group.add_argument(
534+
'--multi-node',
535+
action='store_true',
536+
help='Generate multi-node configurations only'
537+
)
520538
test_config_parser.add_argument(
521539
'-h', '--help',
522540
action='help',

utils/matrix-logic/test_generate_sweep_configs.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,11 +484,13 @@ class TestGenerateRunnerModelSweepConfig:
484484

485485
@pytest.fixture
486486
def runner_sweep_args(self):
487-
"""Args for runner-model-sweep command."""
487+
"""Args for runner-model-sweep command (single-node)."""
488488
args = argparse.Namespace()
489489
args.runner_type = "mi300x"
490490
args.runner_config = "runners.yaml"
491491
args.runner_node_filter = None
492+
args.single_node = True
493+
args.multi_node = False
492494
return args
493495

494496
def test_basic_runner_sweep(self, sample_single_node_config, sample_runner_config, runner_sweep_args):

0 commit comments

Comments
 (0)