Skip to content

Commit 8beb869

Browse files
committed
adding testing workflows
1 parent 0e44f46 commit 8beb869

10 files changed

Lines changed: 1312 additions & 2532 deletions

.github/workflows/e2e-tests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ jobs:
9090
ep: ${{ matrix.config.ep }}
9191
dp-attn: ${{ matrix.config.dp-attn }}
9292
conc: ${{ matrix.config.conc }}
93+
spec-decoding: ${{ matrix.config.spec-decoding }}
94+
disagg: ${{ matrix.config.disagg }}
9395

9496
collect-results:
9597
needs: [test-sweep-multi-node, test-sweep-single-node]

.github/workflows/full-sweep-test.yml

Lines changed: 0 additions & 445 deletions
This file was deleted.

.github/workflows/test-matrix-logic.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,4 @@ jobs:
3333
run: |
3434
cd utils/matrix-logic
3535
pytest test_generate_sweep_configs.py -v
36+
pytest test_validation.py -v

utils/matrix-logic/generate_sweep_configs.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import yaml
33
import argparse
44

5-
from validation import validate_master_config, validate_matrix_output, validate_runner_config, Fields
5+
from validation import validate_master_config, validate_matrix_entry, validate_runner_config, Fields
66

77
seq_len_stoi = {
88
"1k1k": (1024, 1024),
@@ -31,7 +31,7 @@ def generate_full_sweep(args, all_config_data, runner_data):
3131
3232
All filters are optional - can generate sweeps for all configs or filter by specific criteria.
3333
34-
Assumes all_config_data has been validated by validate_config_structure().
34+
Assumes all_config_data has been validated by validate_master_config().
3535
"""
3636
# Validate runner types if specified
3737
if args.runner_type:
@@ -49,6 +49,8 @@ def generate_full_sweep(args, all_config_data, runner_data):
4949
if args.seq_lens:
5050
seq_lens_filter = {seq_len_stoi[sl] for sl in args.seq_lens}
5151

52+
# Iterate through all configurations and apply filters as specified (this is just "selecting"
53+
# configs from all of the master configs subject to some pattern matching)
5254
for key, val in all_config_data.items():
5355
# Filter by model prefix if specified
5456
if args.model_prefix:
@@ -147,7 +149,7 @@ def generate_full_sweep(args, all_config_data, runner_data):
147149
Fields.DISAGG.value: disagg,
148150
}
149151

150-
validate_matrix_output(entry, is_multinode)
152+
validate_matrix_entry(entry, is_multinode)
151153
matrix_values.append(entry)
152154
elif args.single_node:
153155
# Single-node configuration
@@ -198,7 +200,7 @@ def generate_full_sweep(args, all_config_data, runner_data):
198200
if dp_attn is not None:
199201
entry[Fields.DP_ATTN.value] = dp_attn
200202

201-
validate_matrix_output(entry, is_multinode)
203+
validate_matrix_entry(entry, is_multinode)
202204
matrix_values.append(entry)
203205

204206
if conc == conc_end:

0 commit comments

Comments
 (0)