Skip to content

Commit 9bcef10

Browse files
[Fix] Remove MoRI-IO patches from vLLM Disagg benchmarks (#1585)
* fix: remove moriio connector patches after bumping to new nightly vllm image Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> * fix: move read mode envvar to flag Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> * fix: unpin vllm-router image Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> * fix: update to mori_low_latency backend after rename in nightly Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> * fix: pin nightlyies Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> * fix: comments and add perf-changelog.yml Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> * fix: pint router iamge as well Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> * fix: bump vllm nightly versions Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> * fix: add ulimit nofile Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> --------- Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> Co-authored-by: Chun Fang <chun.fang@amd.com>
1 parent 9089fac commit 9bcef10

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

benchmarks/multi_node/amd_utils/job.slurm

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ export DOCKER_CONT_NAME="container_${ENGINE}_${SANITIZED_USER}_${MODEL_NAME}_${S
317317
# vLLM external router container.
318318
# NOTE: vllm/vllm-router only retains ~16 recent nightlies on Docker Hub; older
319319
# dated tags are garbage-collected (manifest unknown)
320-
VLLM_ROUTER_IMAGE="${VLLM_ROUTER_IMAGE:-vllm/vllm-router:nightly-20260617-e667ebb}"
320+
VLLM_ROUTER_IMAGE="${VLLM_ROUTER_IMAGE:-vllm/vllm-router:nightly-20260629-e667ebb}"
321321
ROUTER_CONT_NAME="router_vllm_${SANITIZED_USER}_${SLURM_JOB_ID}"
322322
export RUN_FILE_FULL="$WS_PATH/${RUN_FILE}"
323323

@@ -532,6 +532,7 @@ if [[ \"$ENGINE\" == \"vllm-disagg\" && \"$ROUTER_TYPE\" == \"vllm-router\" && \
532532
\$DOCKER_CMD run -d \
533533
--name \"$ROUTER_CONT_NAME\" \
534534
--network host \
535+
--ulimit nofile=1048576:1048576 \
535536
-v /tmp:/run_logs \
536537
\"$VLLM_ROUTER_IMAGE\" \
537538
bash -lc \"mkdir -p /run_logs/slurm_job-${SLURM_JOB_ID} && exec vllm-router \

configs/amd-master.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1177,7 +1177,7 @@ dsr1-fp8-mi355x-sglang-disagg-mtp:
11771177
- "DECODE_MTP_SIZE=2"
11781178

11791179
kimik2.5-fp4-mi355x-vllm-disagg:
1180-
image: vllm/vllm-openai-rocm:nightly-bf610c2f56764e1b30bc6065f4ceace3d6e59036
1180+
image: vllm/vllm-openai-rocm:v0.24.0
11811181
model: amd/Kimi-K2.5-MXFP4
11821182
model-prefix: kimik2.5
11831183
runner: mi355x-disagg
@@ -1200,7 +1200,6 @@ kimik2.5-fp4-mi355x-vllm-disagg:
12001200
dp-attn: false
12011201
additional-settings:
12021202
- "PREFILL_NODES=1"
1203-
- "VLLM_MORIIO_CONNECTOR_READ_MODE=1"
12041203
decode:
12051204
num-worker: 2
12061205
tp: 8
@@ -1221,7 +1220,6 @@ kimik2.5-fp4-mi355x-vllm-disagg:
12211220
dp-attn: false
12221221
additional-settings:
12231222
- "PREFILL_NODES=1"
1224-
- "VLLM_MORIIO_CONNECTOR_READ_MODE=1"
12251223
decode:
12261224
num-worker: 2
12271225
tp: 8

perf-changelog.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4621,6 +4621,13 @@
46214621
- "1k1k: 1 wide-EP max-throughput + 6 low-latency (DEP16/DEP32 + TP=4) topologies."
46224622
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1780
46234623

4624+
- config-keys:
4625+
- kimik2.5-fp4-mi355x-vllm-disagg
4626+
description:
4627+
- "Bump image to vllm/vllm-openai-rocm:v0.24.0 (MoRI-IO fixes upstreamed in vllm#40344)"
4628+
- "Rename a2a backend mori to mori_low_latency; set read_mode via kv_connector_extra_config instead of VLLM_MORIIO_CONNECTOR_READ_MODE env var"
4629+
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1585
4630+
46244631
- config-keys:
46254632
- dsr1-fp4-b200-dynamo-sglang-mtp
46264633
description:

0 commit comments

Comments
 (0)