Skip to content

Commit aab9482

Browse files
Make exp-name optional in collect-results.yml workflow (#182)
* Initial plan * Make exp-name optional in collect-results.yml and remove from e2e-tests.yml Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com> * Simplify conditional expression in artifact pattern Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com>
1 parent 8a98688 commit aab9482

2 files changed

Lines changed: 11 additions & 12 deletions

File tree

.github/workflows/collect-results.yml

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ on:
44
workflow_call:
55
inputs:
66
exp-name:
7-
required: true
7+
required: false
88
type: string
9+
default: ''
910

1011
jobs:
1112
collect-results:
@@ -22,28 +23,28 @@ jobs:
2223
uses: actions/download-artifact@v5
2324
with:
2425
path: results/
25-
pattern: ${{ inputs.exp-name }}_*
26+
pattern: ${{ inputs.exp-name && format('{0}_*', inputs.exp-name) || '*' }}
2627

2728
- name: Print summary
28-
run: python3 utils/summarize.py results/ ${{ inputs.exp-name }} >> $GITHUB_STEP_SUMMARY
29+
run: python3 utils/summarize.py results/ ${{ inputs.exp-name || 'all' }} >> $GITHUB_STEP_SUMMARY
2930

3031
- name: Aggregate results
31-
run: python3 utils/collect_results.py results/ ${{ inputs.exp-name }}
32+
run: python3 utils/collect_results.py results/ ${{ inputs.exp-name || 'all' }}
3233

3334
- name: Upload aggregated results
3435
uses: actions/upload-artifact@v4
3536
with:
36-
name: results_${{ inputs.exp-name }}
37-
path: agg_${{ inputs.exp-name }}.json
37+
name: results_${{ inputs.exp-name || 'all' }}
38+
path: agg_${{ inputs.exp-name || 'all' }}.json
3839

3940
- name: Plot performance
4041
run: |
4142
pip install -q matplotlib
42-
python3 utils/plot_perf.py results/ ${{ inputs.exp-name }}
43+
python3 utils/plot_perf.py results/ ${{ inputs.exp-name || 'all' }}
4344
- name: Upload performance graphs
4445
uses: actions/upload-artifact@v4
4546
with:
46-
name: graphs_${{ inputs.exp-name }}
47+
name: graphs_${{ inputs.exp-name || 'all' }}
4748
path: |
48-
tput_vs_intvty_*_${{ inputs.exp-name }}.png
49-
tput_vs_e2el_*_${{ inputs.exp-name }}.png
49+
tput_vs_intvty_*_${{ inputs.exp-name || 'all' }}.png
50+
tput_vs_e2el_*_${{ inputs.exp-name || 'all' }}.png

.github/workflows/e2e-tests.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ jobs:
5353
if: ${{ always() }}
5454
uses: ./.github/workflows/collect-results.yml
5555
secrets: inherit
56-
with:
57-
exp-name: ${{ matrix.config.exp-name }}
5856

5957
calc-success-rate:
6058
needs: test-sweep

0 commit comments

Comments
 (0)