Skip to content

Commit bb06a3b

Browse files
committed
fix(agentx): rely on upstream VLLM_PORT handling
Remove the redundant local srt-slurm patch now that main unsets VLLM_PORT for multi-node vLLM endpoints. 中文:依赖上游的 VLLM_PORT 处理。当前 srt-slurm main 已会为跨节点 vLLM 端点取消设置 VLLM_PORT,因此移除冗余的本地补丁。
1 parent 38f2607 commit bb06a3b

3 files changed

Lines changed: 3 additions & 27 deletions

File tree

perf-changelog.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5034,6 +5034,6 @@
50345034
- dsv4-fp4-gb200-dynamo-vllm-agentic-3p1d-dep8-dep16
50355035
description:
50365036
- "Add GB200 Dynamo-vLLM AgentX aggregate TP8 at conc [16] and disaggregated 3P/1D DEP8/DEP16 at conc [1536]."
5037-
- "Use NVIDIA/srt-slurm main with its upstream per-node DP, Dynamo health-count, and Mooncake master fixes; retain the unmerged multi-node TP VLLM_PORT fix. TP8 uses FlashInfer all-reduce and disables vLLM custom all-reduce."
5037+
- "Use NVIDIA/srt-slurm main with its upstream per-node DP, multi-node TP VLLM_PORT, Dynamo health-count, and Mooncake master fixes. TP8 uses FlashInfer all-reduce and disables vLLM custom all-reduce."
50385038
- "Image: vllm/vllm-openai:nightly-dev-arm64-cu13.0.1-c188b96"
50395039
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/2300

runners/launch_gb200-nv.sh

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -298,18 +298,11 @@ fi
298298
# TODO(CJQ): make first class upon srt-slurm upstream refactor
299299
if [[ "$IS_AGENTIC" == "1" ]]; then
300300
# Agentic recipes use NVIDIA/srt-slurm:main. The per-node DP launcher,
301-
# matching Dynamo health counts, and Mooncake master compatibility are all
302-
# upstream; keep only the still-unmerged multi-node TP port fix below.
301+
# matching Dynamo health counts, multi-node TP VLLM_PORT handling, and
302+
# Mooncake master compatibility are all upstream.
303303
git clone --branch main --single-branch https://github.com/NVIDIA/srt-slurm.git "$SRT_REPO_DIR" || exit 1
304304
cd "$SRT_REPO_DIR" || exit 1
305305

306-
# NVIDIA/srt-slurm#243 gives each srt process a private VLLM_PORT range, but
307-
# a multi-node TP process still passes that one range to all of its local
308-
# vLLM children. Unset it only for multi-node non-DP workers, matching the
309-
# still-unmerged NVIDIA/srt-slurm commit de1a4f0257dae5bf871881dc4696e35389c37483.
310-
# Keep the upstream allocation for per-node DP and co-located endpoints.
311-
git apply "$GITHUB_WORKSPACE/runners/patches/srt-slurm-vllm-multinode-tp-port.patch" || exit 1
312-
313306
mkdir -p recipes/vllm/deepseek-v4/agentic || exit 1
314307
cp -rT "$GITHUB_WORKSPACE/benchmarks/multi_node/srt-slurm-recipes/vllm/deepseek-v4/agentic" \
315308
recipes/vllm/deepseek-v4/agentic || exit 1

runners/patches/srt-slurm-vllm-multinode-tp-port.patch

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)