Skip to content

Commit e00d2b9

Browse files
committed
testing pt 6
1 parent 01d6b0e commit e00d2b9

2 files changed

Lines changed: 13 additions & 3 deletions

File tree

perf-changelog.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
- config-keys:
22
- gptoss-fp4-mi300x-vllm
33
description: Test change abc
4+
- config-keys:
5+
- gptoss-fp4-mi325x-vllm
6+
description: Test change abc

utils/process_changelog.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
from pydantic import BaseModel, ConfigDict, Field
77

8-
from pprint import pprint
9-
108
from matrix_logic.validation import load_config_files
119

1210
MASTER_CONFIGS = [".github/configs/amd-master.yaml",
@@ -30,7 +28,16 @@ def get_added_lines(base_ref, head_ref, filepath):
3028

3129
added_lines = []
3230
for line in result.stdout.split('\n'):
33-
if line.startswith('+') and not line.startswith('+++'):
31+
if line.startswith('-') and not line.startswith('---'):
32+
# Don't allow deletions in the changelog
33+
# By convention, it should act as a running log of performance changes,
34+
# so we only want to see additions
35+
raise ValueError(
36+
f"Deletions are not allowed in {filepath}. "
37+
f"Only additions to the changelog are permitted. "
38+
f"Found deleted line: {line[1:]}"
39+
)
40+
elif line.startswith('+') and not line.startswith('+++'):
3441
added_lines.append(line[1:])
3542

3643
return '\n'.join(added_lines)

0 commit comments

Comments
 (0)