Skip to content

Commit e839277

Browse files
cquil11cquil11
committed
adding tests
1 parent 84feeda commit e839277

10 files changed

Lines changed: 33 additions & 1 deletion

‎.github/workflows/benchmark-multinode-tmpl.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ on:
1212
model:
1313
required: true
1414
type: string
15+
model-prefix:
16+
required: true
17+
type: string
1518
framework:
1619
required: true
1720
type: string
@@ -82,6 +85,7 @@ on:
8285
env:
8386
EXP_NAME: ${{ inputs.exp-name }}
8487
IMAGE: ${{ inputs.image }}
88+
MODEL_PREFIX: ${{ inputs.model-prefix }}
8589
FRAMEWORK: ${{ inputs.framework }}
8690
PRECISION: ${{ inputs.precision }}
8791
ISL: ${{ inputs.isl }}

‎.github/workflows/benchmark-tmpl.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ on:
1111
model:
1212
required: true
1313
type: string
14+
model-prefix:
15+
required: true
16+
type: string
1417
precision:
1518
required: true
1619
type: string
@@ -57,6 +60,7 @@ env:
5760
HF_HUB_CACHE: '/mnt/hf_hub_cache/'
5861
EXP_NAME: ${{ inputs.exp-name }}
5962
MODEL: ${{ inputs.model }}
63+
MODEL_PREFIX: ${{ inputs.model-prefix }}
6064
ISL: ${{ inputs.isl }}
6165
OSL: ${{ inputs.osl }}
6266
MAX_MODEL_LEN: ${{ inputs.max-model-len }}

‎.github/workflows/e2e-tests.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ jobs:
5151
runner: ${{ matrix.config.runner }}
5252
image: ${{ matrix.config.image }}
5353
model: ${{ matrix.config.model }}
54+
model-prefix: ${{ matrix.config.model-prefix }}
5455
framework: ${{ matrix.config.framework }}
5556
precision: ${{ matrix.config.precision }}
5657
exp-name: ${{ matrix.config.exp-name }}
@@ -88,6 +89,7 @@ jobs:
8889
runner: ${{ matrix.config.runner }}
8990
image: ${{ matrix.config.image }}
9091
model: ${{ matrix.config.model }}
92+
model-prefix: ${{ matrix.config.model-prefix }}
9193
framework: ${{ matrix.config.framework }}
9294
precision: ${{ matrix.config.precision }}
9395
tp: ${{ matrix.config.tp }}

‎.github/workflows/full-sweep-1k1k-scheduler.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ jobs:
5555
runner: ${{ matrix.config.runner }}
5656
image: ${{ matrix.config.image }}
5757
model: ${{ matrix.config.model }}
58+
model-prefix: ${{ matrix.config.model-prefix }}
5859
framework: ${{ matrix.config.framework }}
5960
precision: ${{ matrix.config.precision }}
6061
exp-name: "dsr1_1k1k"
@@ -92,6 +93,7 @@ jobs:
9293
runner: ${{ matrix.config.runner }}
9394
image: ${{ matrix.config.image }}
9495
model: ${{ matrix.config.model }}
96+
model-prefix: ${{ matrix.config.model-prefix }}
9597
framework: ${{ matrix.config.framework }}
9698
precision: ${{ matrix.config.precision }}
9799
tp: ${{ matrix.config.tp }}
@@ -118,6 +120,7 @@ jobs:
118120
runner: ${{ matrix.config.runner }}
119121
image: ${{ matrix.config.image }}
120122
model: ${{ matrix.config.model }}
123+
model-prefix: ${{ matrix.config.model-prefix }}
121124
framework: ${{ matrix.config.framework }}
122125
precision: ${{ matrix.config.precision }}
123126
exp-name: "dsr1_1k1k"
@@ -155,6 +158,7 @@ jobs:
155158
runner: ${{ matrix.config.runner }}
156159
image: ${{ matrix.config.image }}
157160
model: ${{ matrix.config.model }}
161+
model-prefix: ${{ matrix.config.model-prefix }}
158162
framework: ${{ matrix.config.framework }}
159163
precision: ${{ matrix.config.precision }}
160164
tp: ${{ matrix.config.tp }}

‎.github/workflows/full-sweep-1k8k-scheduler.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ jobs:
5555
runner: ${{ matrix.config.runner }}
5656
image: ${{ matrix.config.image }}
5757
model: ${{ matrix.config.model }}
58+
model-prefix: ${{ matrix.config.model-prefix }}
5859
framework: ${{ matrix.config.framework }}
5960
precision: ${{ matrix.config.precision }}
6061
exp-name: "dsr1_1k8k"
@@ -92,6 +93,7 @@ jobs:
9293
runner: ${{ matrix.config.runner }}
9394
image: ${{ matrix.config.image }}
9495
model: ${{ matrix.config.model }}
96+
model-prefix: ${{ matrix.config.model-prefix }}
9597
framework: ${{ matrix.config.framework }}
9698
precision: ${{ matrix.config.precision }}
9799
tp: ${{ matrix.config.tp }}
@@ -118,6 +120,7 @@ jobs:
118120
runner: ${{ matrix.config.runner }}
119121
image: ${{ matrix.config.image }}
120122
model: ${{ matrix.config.model }}
123+
model-prefix: ${{ matrix.config.model-prefix }}
121124
framework: ${{ matrix.config.framework }}
122125
precision: ${{ matrix.config.precision }}
123126
exp-name: "dsr1_1k8k"
@@ -155,6 +158,7 @@ jobs:
155158
runner: ${{ matrix.config.runner }}
156159
image: ${{ matrix.config.image }}
157160
model: ${{ matrix.config.model }}
161+
model-prefix: ${{ matrix.config.model-prefix }}
158162
framework: ${{ matrix.config.framework }}
159163
precision: ${{ matrix.config.precision }}
160164
tp: ${{ matrix.config.tp }}

‎.github/workflows/full-sweep-8k1k-scheduler.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ jobs:
5555
runner: ${{ matrix.config.runner }}
5656
image: ${{ matrix.config.image }}
5757
model: ${{ matrix.config.model }}
58+
model-prefix: ${{ matrix.config.model-prefix }}
5859
framework: ${{ matrix.config.framework }}
5960
precision: ${{ matrix.config.precision }}
6061
exp-name: "dsr1_8k1k"
@@ -92,6 +93,7 @@ jobs:
9293
runner: ${{ matrix.config.runner }}
9394
image: ${{ matrix.config.image }}
9495
model: ${{ matrix.config.model }}
96+
model-prefix: ${{ matrix.config.model-prefix }}
9597
framework: ${{ matrix.config.framework }}
9698
precision: ${{ matrix.config.precision }}
9799
tp: ${{ matrix.config.tp }}
@@ -118,6 +120,7 @@ jobs:
118120
runner: ${{ matrix.config.runner }}
119121
image: ${{ matrix.config.image }}
120122
model: ${{ matrix.config.model }}
123+
model-prefix: ${{ matrix.config.model-prefix }}
121124
framework: ${{ matrix.config.framework }}
122125
precision: ${{ matrix.config.precision }}
123126
exp-name: "dsr1_8k1k"
@@ -155,6 +158,7 @@ jobs:
155158
runner: ${{ matrix.config.runner }}
156159
image: ${{ matrix.config.image }}
157160
model: ${{ matrix.config.model }}
161+
model-prefix: ${{ matrix.config.model-prefix }}
158162
framework: ${{ matrix.config.framework }}
159163
precision: ${{ matrix.config.precision }}
160164
tp: ${{ matrix.config.tp }}

‎utils/matrix-logic/generate_sweep_configs.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ def generate_full_sweep(args, all_config_data, runner_data):
142142
entry = {
143143
Fields.IMAGE.value: image,
144144
Fields.MODEL.value: model,
145+
Fields.MODEL_PREFIX.value: model_code,
145146
Fields.PRECISION.value: precision,
146147
Fields.FRAMEWORK.value: framework,
147148
Fields.RUNNER.value: runner,
@@ -200,6 +201,7 @@ def generate_full_sweep(args, all_config_data, runner_data):
200201
entry = {
201202
Fields.IMAGE.value: image,
202203
Fields.MODEL.value: model,
204+
Fields.MODEL_PREFIX.value: model_code,
203205
Fields.PRECISION.value: precision,
204206
Fields.FRAMEWORK.value: framework,
205207
Fields.RUNNER.value: runner,
@@ -302,6 +304,7 @@ def get_lowest_conc(search_space_entry):
302304
entry = {
303305
Fields.IMAGE.value: val[Fields.IMAGE.value],
304306
Fields.MODEL.value: val[Fields.MODEL.value],
307+
Fields.MODEL_PREFIX.value: model_code,
305308
Fields.PRECISION.value: val[Fields.PRECISION.value],
306309
Fields.FRAMEWORK.value: val[Fields.FRAMEWORK.value],
307310
Fields.RUNNER.value: node,
@@ -343,6 +346,7 @@ def get_lowest_conc(search_space_entry):
343346
entry = {
344347
Fields.IMAGE.value: val[Fields.IMAGE.value],
345348
Fields.MODEL.value: val[Fields.MODEL.value],
349+
Fields.MODEL_PREFIX.value: model_code,
346350
Fields.PRECISION.value: val[Fields.PRECISION.value],
347351
Fields.FRAMEWORK.value: val[Fields.FRAMEWORK.value],
348352
Fields.RUNNER.value: node,

‎utils/matrix-logic/test_validation.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ def valid_single_node_matrix_entry():
2727
return {
2828
"image": "rocm/7.0:rocm7.0_ubuntu_22.04_sgl-dev-v0.5.2-rocm7.0-mi35x-20250915",
2929
"model": "amd/DeepSeek-R1-0528-MXFP4-Preview",
30+
"model-prefix": "dsr1",
3031
"precision": "fp4",
3132
"framework": "sglang",
3233
"spec-decoding": "none",
@@ -49,6 +50,7 @@ def valid_multinode_matrix_entry():
4950
return {
5051
"image": "nvcr.io#nvidia/ai-dynamo/tensorrtllm-runtime:0.5.1-rc0.pre3",
5152
"model": "deepseek-r1-fp4",
53+
"model-prefix": "dsr1",
5254
"precision": "fp4",
5355
"framework": "dynamo-trt",
5456
"spec-decoding": "none",

‎utils/matrix-logic/validation.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ class SingleNodeMatrixEntry(BaseModel):
6868

6969
image: str
7070
model: str
71+
model_prefix: str = Field(alias=Fields.MODEL_PREFIX.value)
7172
precision: str
7273
framework: str
7374
spec_decoding: Literal["mtp", "draft_model", "none"] = Field(
@@ -104,6 +105,7 @@ class MultiNodeMatrixEntry(BaseModel):
104105

105106
image: str
106107
model: str
108+
model_prefix: str = Field(alias=Fields.MODEL_PREFIX.value)
107109
precision: str
108110
framework: str
109111
spec_decoding: Literal["mtp", "draft_model", "none"] = Field(

‎utils/process_result.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,11 @@ def get_required_env_vars(required_vars):
2525
# Base required env vars
2626
base_env = get_required_env_vars([
2727
'RUNNER_TYPE', 'FRAMEWORK', 'PRECISION', 'SPEC_DECODING',
28-
'RESULT_FILENAME', 'ISL', 'OSL', 'DISAGG'
28+
'RESULT_FILENAME', 'ISL', 'OSL', 'DISAGG', 'MODEL_PREFIX'
2929
])
3030

3131
hw = base_env['RUNNER_TYPE']
32+
model_prefix = base_env['MODEL_PREFIX']
3233
framework = base_env['FRAMEWORK']
3334
precision = base_env['PRECISION']
3435
spec_decoding = base_env['SPEC_DECODING']
@@ -44,6 +45,7 @@ def get_required_env_vars(required_vars):
4445
'hw': hw,
4546
'conc': int(bmk_result['max_concurrency']),
4647
'model': bmk_result['model_id'],
48+
'infmax_model_prefix': model_prefix,
4749
'framework': framework,
4850
'precision': precision,
4951
'spec_decoding': spec_decoding,

0 commit comments

Comments
 (0)