Skip to content

Commit f495ab7

Browse files
hyukjleeclaude
andcommitted
[AMD][AgentX] kimik3: force lm-eval and add an fp8 kvnone c8 eval arm
run_eval defaults agentic scenarios to swebench (benchmark_lib.sh:1464), but EVAL_FRAMEWORK wins over that default at :1471. Export it as lm-eval the way minimaxm3_fp4_mi355x.sh does, left overridable so EVAL_FRAMEWORK=swebench can still reach the SWE-bench path this recipe already carries. The eval arm runs the one config proven on this stack: fp8 KV, no offload, c8 -- the control from run 30442578333 (696 tok/s/GPU), repeated clean in 30453589555. The offload arm is deliberately excluded; it is 3/3 dead under fp8 and is being isolated separately by the fp8b64 key. Dispatch with --evals-only: mark_eval_entries flips single-node agentic rows to run-eval=True (generate_sweep_configs.py:360), yielding one eval-only cell. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent d78983b commit f495ab7

2 files changed

Lines changed: 31 additions & 0 deletions

File tree

benchmarks/single_node/agentic/kimik3_fp4_mi355x.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,14 @@ set -x
5353

5454
source "$(dirname "$0")/../../benchmark_lib.sh"
5555

56+
# Force the eval framework to lm-eval, matching minimaxm3_fp4_mi355x.sh.
57+
# run_eval derives its default as swebench for agentic scenarios
58+
# (scenario_default=swebench when IS_AGENTIC/SCENARIO_TYPE=agentic-coding), but
59+
# EVAL_FRAMEWORK takes precedence over that default
60+
# (benchmark_lib.sh:1471 framework=${EVAL_FRAMEWORK:-...}). Left overridable so
61+
# the SWE-bench path below can still be selected with EVAL_FRAMEWORK=swebench.
62+
export EVAL_FRAMEWORK="${EVAL_FRAMEWORK:-lm-eval}"
63+
5664
check_env_vars MODEL TP CONC KV_OFFLOADING TOTAL_CPU_DRAM_GB RESULT_DIR DURATION EP_SIZE
5765

5866
if [[ -n "${SLURM_JOB_ID:-}" ]]; then

configs/amd-master.yaml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -775,6 +775,29 @@ kimik3-fp4-mi355x-vllm-agentic-fp8retry:
775775
- { tp: 8, kv-offloading: none, conc-list: [1, 16] }
776776
- { tp: 8, kv-offloading: dram, kv-offload-backend: { name: vllm-simple-fp8 }, conc-list: [8] }
777777

778+
kimik3-fp4-mi355x-vllm-agentic-fp8eval:
779+
# lm-eval on the one config that is actually proven on this stack: fp8 KV,
780+
# no offload, c8 -- the control cell from run 30442578333 (696 tok/s/GPU),
781+
# repeated clean in 30453589555. The offload arm is excluded on purpose: it
782+
# has failed 3/3 under fp8 (see the fp8b64 key below).
783+
#
784+
# The recipe pins EVAL_FRAMEWORK=lm-eval, so this runs lm-eval rather than
785+
# run_eval's swebench default for agentic scenarios. Dispatch with
786+
# --evals-only; mark_eval_entries flips single-node agentic rows to
787+
# run-eval=True (generate_sweep_configs.py:360).
788+
image: vllm/vllm-openai-rocm:kimi-k3
789+
model: moonshotai/Kimi-K3
790+
model-prefix: kimik3
791+
runner: cluster:mi355x-amds
792+
precision: fp4
793+
framework: vllm
794+
multinode: false
795+
scenarios:
796+
agentic-coding:
797+
- dram-utilization: 0.80
798+
search-space:
799+
- { tp: 8, kv-offloading: none, conc-list: [8] }
800+
778801
kimik3-fp4-mi355x-vllm-agentic-fp8b64:
779802
# One variable off the cell that has now failed 3/3: fp8 KV + the
780803
# SimpleCPUOffloadConnector, with the KV page pinned to 64 tokens.

0 commit comments

Comments
 (0)