Skip to content

Commit fded89f

Browse files
committed
feat(evals): allow AgentX framework override
1 parent 1870df8 commit fded89f

3 files changed

Lines changed: 28 additions & 0 deletions

File tree

.github/workflows/benchmark-tmpl.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,11 @@ on:
121121
required: false
122122
type: string
123123
default: ""
124+
eval-framework:
125+
description: "Explicit eval framework override"
126+
required: false
127+
type: string
128+
default: ""
124129
swebench-gen-mode:
125130
description: "SWE-bench generation mode (single-shot | agentic). Empty = agentic (single-shot is an explicit debugging escape hatch)."
126131
required: false
@@ -162,6 +167,7 @@ env:
162167
TOTAL_CPU_DRAM_GB: ${{ inputs.total-cpu-dram-gb }}
163168
DURATION: ${{ inputs.duration }}
164169
EVAL_LIMIT: ${{ inputs.eval-limit }}
170+
EVAL_FRAMEWORK: ${{ inputs.eval-framework }}
165171
SWEBENCH_GEN_MODE: ${{ inputs.swebench-gen-mode }}
166172
AIPERF_FAILED_REQUEST_THRESHOLD: '0.10'
167173
RESULT_DIR: /workspace/results

.github/workflows/e2e-tests.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ on:
2626
required: false
2727
type: string
2828
default: ""
29+
eval-framework:
30+
description: "Explicit eval framework override (for example, lm-eval on an agentic recipe)"
31+
required: false
32+
type: string
33+
default: ""
2934
swebench-gen-mode:
3035
description: "SWE-bench generation mode (single-shot | agentic). Empty = agentic (single-shot is an explicit debugging escape hatch)."
3136
required: false
@@ -55,6 +60,11 @@ on:
5560
required: false
5661
type: string
5762
default: ""
63+
eval-framework:
64+
description: "Explicit eval framework override (for example, lm-eval on an agentic recipe)"
65+
required: false
66+
type: string
67+
default: ""
5868
swebench-gen-mode:
5969
description: "SWE-bench generation mode (single-shot | agentic). Empty = agentic (single-shot is an explicit debugging escape hatch)."
6070
required: false
@@ -280,6 +290,7 @@ jobs:
280290
run-eval: true
281291
eval-only: true
282292
eval-limit: ${{ inputs.eval-limit }}
293+
eval-framework: ${{ inputs.eval-framework }}
283294
swebench-gen-mode: ${{ inputs.swebench-gen-mode }}
284295
scenario-type: agentic-coding
285296
ref: ${{ inputs.ref }}

utils/evals/test_run_eval_dispatch.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,17 @@ def test_default_graded_eval_suite_is_registered():
342342
)
343343

344344

345+
def test_agentic_eval_workflow_forwards_framework_override():
346+
repo_root = BENCHMARK_LIB.parents[1]
347+
e2e_workflow = (repo_root / ".github/workflows/e2e-tests.yml").read_text()
348+
benchmark_workflow = (
349+
repo_root / ".github/workflows/benchmark-tmpl.yml"
350+
).read_text()
351+
352+
assert "eval-framework: ${{ inputs.eval-framework }}" in e2e_workflow
353+
assert "EVAL_FRAMEWORK: ${{ inputs.eval-framework }}" in benchmark_workflow
354+
355+
345356
def test_swebench_single_shot_registers_task_yaml():
346357
script = r'''
347358
source "$BENCHMARK_LIB"

0 commit comments

Comments
 (0)