[codex] Recover PR 1798 ingest without rerunning sweep#1819
Merged
Conversation
Collaborator
Author
|
Recovery validation is complete:
After this lands on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The push-to-main run failed in setup because PR #1798 corrected the malformed PR #1767 changelog indentation. The changelog processor rejects non-whitespace deletions, so artifact reuse and ingest never ran.
Safety
[skip-sweep]recover-pr-1798confirmation inputValidation
actionlint .github/workflows/recover-pr-1798-ingest.ymlNote
Medium Risk
Touches production ingest via repository dispatch and uses a one-off changelog/git reconstruction; mitigated by hard-coded run/SHA checks, artifact validation, and no GPU matrix.
Overview
Adds a manually dispatched GitHub Actions workflow (
recover-pr-1798-ingest.yml) to finish database ingest for PR #1798 after the post-mergerun-sweeppush failed in setup, without rerunning benchmarks on GPU.The workflow mirrors the existing PR #1767 recovery pattern but pins specific failed push run/job IDs and a successful PR sweep run (attempt 2), and requires typing
recover-pr-1798to run. It validates those runs via the GitHub API (event, workflow path, SHAs, conclusions, non-expiredresults_bmk/eval_results_all/run-statsartifacts).It reconstructs the sweep config by building a synthetic tree from the merge commit: a
perledit onperf-changelog.yamlundoes the unrelated PR #1767 indentation fix soprocess_changelog.pydoes not treat it as a forbidden deletion, then runs the validator and uploads artifacts plus changelog metadata. Finally it dispatchesingest-resultstoInferenceX-appwith the recovery run id.Reviewed by Cursor Bugbot for commit 9f0a805. Bugbot is set up for automated code reviews on this repo. Configure here.