Update kimik2.5-int4-mi300x-vllm vLLM image to v0.20.2 #1350
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2343,3 +2343,9 @@ | |
| description: | ||
| - "Add Qwen3.5-397B-A17B FP8 MI355X ATOM benchmark configs with and without MTP" | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1310 | ||
|
|
||
| - config-keys: | ||
| - kimik2.5-int4-mi300x-vllm | ||
| description: | ||
| - "Update vLLM ROCm image from v0.18.0 to v0.20.2" | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX | ||
|
Check failure on line 2351 in perf-changelog.yaml
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The new perf-changelog entry at line 2351 has
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX— the literalXXXplaceholder from the PR template was not replaced with the actual PR number. This will produce a 404 link in the changelog; fix by replacingXXXwith1350.Extended reasoning...
What's wrong
perf-changelog.yamlline 2351 reads:The
XXXis a stub from the "Updating Docker Images" section ofAGENTS.md, where the template literally showspull/XXXas a placeholder for authors to fill in. The author/generator of this PR copied the template but didn't substitute the actual PR number.Why this is the only such case
Every other entry in
perf-changelog.yamluses a real numeric PR id — e.g. line 2332 →pull/1305, line 2338 →pull/1308, line 2345 →pull/1310. A grep for non-numericpr-linkvalues turns up exactly one hit: the new entry added by this PR. So this is clearly an authoring oversight, not a convention.Impact
When this is merged, the changelog entry for the
kimik2.5-int4-mi300x-vllmv0.18.0 → v0.20.2 image bump will link togithub.com/SemiAnalysisAI/InferenceX/pull/XXX, which 404s. Anyone using the changelog to trace a performance change back to its PR for this entry will hit a dead link, breaking changelog→PR traceability. No runtime/benchmark impact — purely a metadata/documentation issue, hence nit severity.Step-by-step proof
<pr number="1350">).perf-changelog.yamlentry whosepr-linkends in/pull/XXX(diff hunk atperf-changelog.yaml:2346–2351).XXXis not a valid GitHub PR number; navigating tohttps://github.com/SemiAnalysisAI/InferenceX/pull/XXXreturns a 404.XXXwith1350(this PR's number) yields a working link to the merge commit, restoring traceability.Fix