Update minimaxm2.5-fp8-mi300x-vllm vLLM image to v0.20.2 #1351
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2343,3 +2343,9 @@ | |
| description: | ||
| - "Add Qwen3.5-397B-A17B FP8 MI355X ATOM benchmark configs with and without MTP" | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1310 | ||
|
|
||
| - config-keys: | ||
| - minimaxm2.5-fp8-mi300x-vllm | ||
| description: | ||
| - "Update vLLM ROCm image from v0.16.0 to v0.20.2" | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX | ||
|
Check failure on line 2351 in perf-changelog.yaml
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The new perf-changelog.yaml entry has
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXXwith a literalXXXplaceholder rather than the actual PR number. Please replaceXXXwith1351before merging so the changelog link resolves to this PR instead of 404.Extended reasoning...
What's wrong
The new entry added to
perf-changelog.yamlat the end of the file contains an unresolved placeholder in thepr-linkfield:The literal string
XXXwas left in place where the PR number should be.Why this matters
Every other entry in
perf-changelog.yamlreferences a real PR number (e.g./pull/1303,/pull/1304,/pull/1308,/pull/1310). Thepr-linkis the changelog's way of tracing a config change back to its motivating PR, so consumers (humans browsing the changelog, or any tooling that follows these links) will be sent tohttps://github.com/SemiAnalysisAI/InferenceX/pull/XXX— a 404. The provenance for this image bump is effectively lost the moment the PR is merged and someone tries to follow the link.Step-by-step proof
perf-changelog.yamlat line 2348 (the new block added by this PR).pr-link:value — it is the verbatim stringhttps://github.com/SemiAnalysisAI/InferenceX/pull/XXX.pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1310) or earlier entries pointing to/pull/1303,/pull/1304,/pull/1308— all use real, numeric PR IDs./pull/1351.Fix
Replace the trailing
XXXwith1351:Severity
Calling this nit:
perf-changelog.yamlis documentation/metadata, so there is no runtime impact, no failing CI, and no broken benchmark. But it is a guaranteed-broken link being added by this very PR, and the fix is a one-character-class substitution, so it is well worth catching before merge.