-
Notifications
You must be signed in to change notification settings - Fork 186
Update kimik2.5-fp4-b200-vllm vLLM image to v0.21.0 #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
functionstackx
merged 8 commits into
main
from
claude/issue-1154-kimik2.5-fp4-b200-vllm
May 18, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bd3726a
$Update kimik2.5-fp4-b200-vllm vLLM image to v0.20.2\n\nRef #1154\n\n…
github-actions[bot] 72c0408
Merge branch 'main' into claude/issue-1154-kimik2.5-fp4-b200-vllm
Oseltamivir c29c3c5
Merge remote-tracking branch 'origin/main' into HEAD
90bc2f0
Merge remote-tracking branch 'origin/main' into HEAD
74f16dc
fix(kimik2.5_fp4_b200.sh): raise --gpu-memory-utilization 0.90 -> 0.98
d4eb103
Merge remote-tracking branch 'origin/main' into HEAD
0560179
fix(kimik2.5_fp4_b200.sh): disable CUDA-graph memory estimator + rest…
ff81738
Merge remote-tracking branch 'origin/main' into pr-1395-reuse
functionstackx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The PR title and description state the vLLM image is being bumped to v0.21.0, but the actual diff updates the image to v0.20.2 in both nvidia-master.yaml (line 2503) and the perf-changelog.yaml entry. This is a metadata-only mismatch — please reconcile before merge by either updating the title/description to say v0.20.2, or bumping the YAML/changelog to v0.21.0 if that was the intended target.
Extended reasoning...
The mismatch
The PR title is "Update kimik2.5-fp4-b200-vllm vLLM image to v0.21.0" and the description states "Updates the vLLM image tag for kimik2.5-fp4-b200-vllm from v0.17.0 to v0.21.0".
However, the actual diff tells a different story:
.github/configs/nvidia-master.yamlline 2503 changes fromimage: vllm/vllm-openai:v0.17.0toimage: vllm/vllm-openai:v0.20.2perf-changelog.yamlentry describes the change as "Update vLLM image from v0.17.0 to v0.20.2"So the YAML and the changelog are internally consistent at v0.20.2, while the PR title and description both claim v0.21.0.
Step-by-step proof
Update kimik2.5-fp4-b200-vllm vLLM image to v0.21.0.Updates the vLLM image tag for kimik2.5-fp4-b200-vllm from v0.17.0 to v0.21.0..github/configs/nvidia-master.yaml:perf-changelog.yaml:Impact
This is metadata-only — when this PR merges, the deployed image will be
vllm/vllm-openai:v0.20.2as written in the YAML, not v0.21.0. The PR title and description don't affect the runtime behavior. However:git logwill see a commit message claiming a v0.21.0 bump that didn't actually happen.How to fix
Reconcile by either:
Update kimik2.5-fp4-b200-vllm vLLM image to v0.20.2and update the description body to match, since the YAML and changelog both consistently say v0.20.2.nvidia-master.yamlline 2503 tov0.21.0and update theperf-changelog.yamldescription accordingly.Given that the YAML and the auto-generated changelog entry agree on v0.20.2, Option A appears to be the actual intent.