-
Notifications
You must be signed in to change notification settings - Fork 186
[Klaud Cold] Update minimaxm2.5-fp8-b300-vllm vLLM image to v0.21.0 #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
functionstackx
merged 3 commits into
main
from
update-minimaxm2.5-fp8-b300-vllm-v0.21.0
May 18, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 The divergence comment block at .github/configs/nvidia-master.yaml:4329-4332 becomes stale after this bump: it still claims the b300-vllm entry is 'left identical to origin/main' (no longer true) and records the divergence as 'v0.19.0-cu130 -> v0.19.1' when the actual divergence is now 'v0.21.0 -> v0.19.1' (with b300-vllm-agentic at line 4334 still pinned to v0.19.1). Either update the comment to reflect the new divergence, or reconsider whether bumping b300-vllm while leaving b300-vllm-agentic pinned is intended.
Extended reasoning...
What the bug is\n\nThis PR bumps
minimaxm2.5-fp8-b300-vllmat.github/configs/nvidia-master.yaml:4306fromvllm/vllm-openai:v0.19.0-cu130tovllm/vllm-openai:v0.21.0, but does not touch the adjacent divergence comment block at lines 4329-4332 that documents this exact image. The b300-vllm-agentic sibling at line 4334 remains pinned tovllm/vllm-openai:v0.19.1.\n\n### Why both claims in the comment are now wrong\n\nThe comment currently reads:\n\nyaml\n# Diverged from minimaxm2.5-fp8-b300-vllm (agentic-coding sibling). Reasons below;\n# the original minimaxm2.5-fp8-b300-vllm entry is left identical to origin/main so\n# its fixed-seq-len sweep is unaffected.\n# - image: 'vllm/vllm-openai:v0.19.0-cu130' -> 'vllm/vllm-openai:v0.19.1'\n\n\n1. Claim 1 — 'left identical to origin/main': This PR explicitly modifies the b300-vllm entry, so it is no longer identical to origin/main. The rationale for forking the -agentic sibling (preserving an unchanged fixed-seq-len sweep history on the upstream image) is no longer being honored.\n2. Claim 2 — divergence delta: The recorded delta'v0.19.0-cu130' -> 'v0.19.1'is now inaccurate on both sides: the upstream b300-vllm is nowv0.21.0(different version,-cu130suffix dropped), so the actual divergence becomesv0.21.0 -> v0.19.1.\n\n### Step-by-step proof\n\n1.git blameshows the comment was introduced by commite92a9bf9(Cameron Quilici, 'Migrate agentic-coding benchmarks to aiperf v0.2'). At that time, b300-vllm was onv0.19.0-cu130and the -agentic sibling was intentionally forked tov0.19.1to keep the original sweep on the upstream image.\n2. This PR changes line 4306image: vllm/vllm-openai:v0.19.0-cu130→image: vllm/vllm-openai:v0.21.0.\n3. Line 4334 (b300-vllm-agentic image) is untouched by this PR — it still readsvllm/vllm-openai:v0.19.1.\n4. Lines 4329-4332 are also untouched — they still describe the prior divergence delta and assert b300-vllm is identical to origin/main.\n5. Therefore, after the merge, the comment misrepresents both the divergence delta (saysv0.19.0-cu130 -> v0.19.1, actuallyv0.21.0 -> v0.19.1) and the design invariant (says b300-vllm is unchanged from origin/main, but it just changed).\n\n### Impact and fix\n\nThe comment is pure YAML#-prefixed text — there is no runtime impact and the sweep configuration itself is consistent. However, the comment actively misleads future readers and reviewers about why the -agentic sibling exists as a separate entry. The fix is to either (a) update the comment block to record the newv0.21.0 -> v0.19.1divergence and drop the 'identical to origin/main' wording, or (b) also bump b300-vllm-agentic to v0.21.0 in this PR so the divergence is closed and the comment can be removed entirely. The b200 sibling block at lines 4278-4282 is unaffected.