Skip to content

[WIP] [NV] Add Kimi K2.5 FP4 B200/B300 EP sweep#1658

Open
jasonlizhengjian wants to merge 5 commits into
mainfrom
nv/jasonli/kimi-k25-b200-b300-ep-sweep
Open

[WIP] [NV] Add Kimi K2.5 FP4 B200/B300 EP sweep#1658
jasonlizhengjian wants to merge 5 commits into
mainfrom
nv/jasonli/kimi-k25-b200-b300-ep-sweep

Conversation

@jasonlizhengjian

@jasonlizhengjian jasonlizhengjian commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Add expert-parallel sweep points for Kimi K2.5 FP4 B200/B300 vLLM aggregate benchmarks.

Conditionally enables vLLM expert parallelism when EP_SIZE > 1.


Note

Low Risk
Benchmark config and launch-script changes only; no production serving or auth paths affected.

Overview
Extends Kimi K2.5 FP4 fixed-seq-len sweeps on B200 and B300 vLLM with expert-parallel (ep: 8 at tp: 8, ep: 4 at tp: 4) for both 1k1k and 8k1k, each with its own concurrency range.

The B200/B300 benchmark scripts now require EP_SIZE and pass --enable-expert-parallel only when EP_SIZE > 1, matching the repo’s vLLM MoE pattern. The B200 script also documents/disables the CUDA-graph memory profiler via VLLM_MEMORY_PROFILER_ESTIMATE_CUDAGRAPHS=0 so KV cache sizing stays consistent with gpu-memory-utilization=0.90.

perf-changelog.yaml records the new sweep for kimik2.5-fp4-b200-vllm and kimik2.5-fp4-b300-vllm.

Reviewed by Cursor Bugbot for commit 8e4f369. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

2 similar comments
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@jasonlizhengjian jasonlizhengjian marked this pull request as draft June 4, 2026 19:36
@jasonlizhengjian jasonlizhengjian changed the title [NV] Add Kimi K2.5 FP4 B200/B300 EP sweep [WIP] [NV] Add Kimi K2.5 FP4 B200/B300 EP sweep Jun 9, 2026
@jasonlizhengjian jasonlizhengjian marked this pull request as ready for review June 9, 2026 18:41
@claude

claude Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @jasonlizhengjian's task in 1m 49s —— View job


Review of PR #1658

  • Read changed files and PR diff
  • Validate master config changes
  • Validate perf-changelog.yaml
  • Validate benchmark scripts (EP pattern, code style)
  • Post review findings

LGTM — no blocking issues found.

What was checked:

  • Master config + perf-changelog: nvidia-master.yaml modified and perf-changelog.yaml updated with a new entry appended to the end of the file. ✓
  • Container images: vllm/vllm-openai:v0.22.1 is publicly accessible on Docker Hub. ✓
  • EP conditional pattern: Both B200 and B300 scripts use the correct if [ "$EP_SIZE" -gt 1 ] guard with --enable-expert-parallel (boolean flag, as required for vLLM). ✓
  • check_env_vars: Both scripts now require EP_SIZE. ✓
  • Code style: vllm serve arguments are on separate lines with \ continuations. ✓
  • Sweep points: EP points are symmetric across B200/B300 and across both ISL scenarios (1k/1k and 8k/1k). ✓

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant