From 1ab04adbeb78a8c5c0840aefffcfa5c7110b216d Mon Sep 17 00:00:00 2001 From: Ankur-singh Date: Mon, 8 Jun 2026 12:09:05 -0700 Subject: [PATCH] Fix CHAT_TEMPLATE_KWARGS_ON default quoting in dsv4_fp4_b300_vllm speedbench MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bash ends `${VAR:-{...}}` parameter expansion at the first `}`, so the trailing brace was appended as a literal — yielding `{...}}` when the workflow exported a non-default value, breaking the thinking-on cells. Move the JSON default into its own variable so the expansion contains no brace literals. --- benchmarks/single_node/speedbench/dsv4_fp4_b300_vllm.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/benchmarks/single_node/speedbench/dsv4_fp4_b300_vllm.sh b/benchmarks/single_node/speedbench/dsv4_fp4_b300_vllm.sh index 7e39c32b3..2a77dcb36 100755 --- a/benchmarks/single_node/speedbench/dsv4_fp4_b300_vllm.sh +++ b/benchmarks/single_node/speedbench/dsv4_fp4_b300_vllm.sh @@ -48,7 +48,8 @@ TEMPERATURE="${TEMPERATURE:-1.0}" # thinking-on chat_template_kwargs. MUST match the production/golden config: # the reference matrix (benchmarks/speedbench-reference-al.yaml) was measured # with reasoning_effort=high. -CHAT_TEMPLATE_KWARGS_ON="${CHAT_TEMPLATE_KWARGS_ON:-{\"thinking\": true, \"reasoning_effort\": \"high\"}}" +DEFAULT_CHAT_TEMPLATE_KWARGS_ON='{"thinking": true, "reasoning_effort": "high"}' +CHAT_TEMPLATE_KWARGS_ON="${CHAT_TEMPLATE_KWARGS_ON:-$DEFAULT_CHAT_TEMPLATE_KWARGS_ON}" SPEEDBENCH_DIR="${SPEEDBENCH_DIR:-/workspace/speed_bench_data}" RESULTS_DIR="${RESULTS_DIR:-/workspace/speedbench_results}"