Skip to content

[NVIDIA] chore: remove h200-trt runner type#185

Merged
cquil11 merged 6 commits into
mainfrom
remove-h200-trt-label
Nov 6, 2025
Merged

[NVIDIA] chore: remove h200-trt runner type#185
cquil11 merged 6 commits into
mainfrom
remove-h200-trt-label

Conversation

@cquil11
Copy link
Copy Markdown
Collaborator

@cquil11 cquil11 commented Nov 6, 2025

The set of runners with label h200 is actually the same as the set of runners with label h200-trt. So we can just remove the h200-trt label from all H200 runner nodes and remove from the codebase accordingly.

Ran the following test sweep across runner type h200 and framework trt: https://github.com/InferenceMAX/InferenceMAX/actions/runs/19142142469
https://github.com/InferenceMAX/InferenceMAX/actions/runs/19142146665
https://github.com/InferenceMAX/InferenceMAX/actions/runs/19142152143

Invoked by running the E2E Tests workflow with the command:

full-sweep --test-mode --seq-lens 1k1k --framework trt --runner-type h200 --config-files .github/configs/nvidia-master.yaml --runner-config .github/configs/runners.yaml

@cquil11 cquil11 marked this pull request as ready for review November 6, 2025 15:17
@cquil11 cquil11 requested a review from a team as a code owner November 6, 2025 15:17
Copilot AI review requested due to automatic review settings November 6, 2025 15:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2025

📊 Line Count Report

File: utils/matrix-logic/generate_sweep_configs.py

Total Lines: 956

Base Lines: 956

Change: No change ➡️

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the redundant h200-trt runner type label, consolidating all H200 runners under the single h200 label since both labels map to the same set of runner nodes.

  • Removed h200-trt entries from runner configuration and color mapping
  • Updated documentation and help text to reference b200-trt instead of h200-trt as example
  • Modified workflow logic to eliminate duplicate h200 runner type generation

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
utils/plot_perf.py Removed h200-trt color mapping entry
utils/matrix-logic/generate_sweep_configs.py Updated help text examples to use b200-trt instead of h200-trt
.github/workflows/full-sweep-test.yml Simplified runner type logic to avoid duplicate h200 entries
.github/configs/runners.yaml Removed the entire h200-trt runner type configuration
.github/configs/nvidia-master.yaml Updated runner references from h200-trt to h200
.github/configs/CONFIGS.md Updated documentation example from h200-trt to b200-trt
.github/README.md Updated example command to use b200-trt instead of h200-trt

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/full-sweep-test.yml Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2025

📊 Line Count Report

File: utils/matrix-logic/generate_sweep_configs.py

Total Lines: 956

Base Lines: 956

Change: No change ➡️

Comment thread utils/plot_perf.py
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2025

📊 Line Count Report

File: utils/matrix-logic/generate_sweep_configs.py

Total Lines: 956

Base Lines: 956

Change: No change ➡️

Copy link
Copy Markdown
Collaborator

@kimbochen kimbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie lgtm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2025

📊 Line Count Report

File: utils/matrix-logic/generate_sweep_configs.py

Total Lines: 956

Base Lines: 956

Change: No change ➡️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2025

📊 Line Count Report

File: utils/matrix-logic/generate_sweep_configs.py

Total Lines: 956

Base Lines: 956

Change: No change ➡️

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 6, 2025

📊 Line Count Report

File: utils/matrix-logic/generate_sweep_configs.py

Total Lines: 956

Base Lines: 956

Change: No change ➡️

@cquil11 cquil11 merged commit 403857f into main Nov 6, 2025
17 checks passed
@cquil11 cquil11 deleted the remove-h200-trt-label branch November 6, 2025 16:31
@cquil11 cquil11 added the NVIDIA label Apr 8, 2026
@cquil11 cquil11 changed the title chore: remove h200-trt runner type [NVIDIA] chore: remove h200-trt runner type Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants