Skip to content

Remove unlabeled trigger from label-validation workflow#207

Merged
functionstackx merged 2 commits into
mainfrom
copilot/remove-pull-on-unlabel
Nov 9, 2025
Merged

Remove unlabeled trigger from label-validation workflow#207
functionstackx merged 2 commits into
mainfrom
copilot/remove-pull-on-unlabel

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 9, 2025

Race condition occurs when quickly labeling/unlabeling PRs to re-trigger validation - both events fire simultaneously despite concurrency controls.

Changes

  • Removed unlabeled from workflow triggers in .github/workflows/label-validation.yml
  • Workflow now triggers only on labeled and synchronize events

Before:

on:
  pull_request:
    types: [labeled, unlabeled, synchronize]

After:

on:
  pull_request:
    types: [labeled, synchronize]

Users must add a new label to re-trigger validation instead of unlabeling/relabeling.

View original Slack conversation


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ce conditions

Co-authored-by: functionstackx <47992694+functionstackx@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove pull on unlabel for label validation Remove unlabeled trigger from label-validation workflow Nov 9, 2025
Copilot AI requested a review from functionstackx November 9, 2025 22:24
@functionstackx functionstackx marked this pull request as ready for review November 9, 2025 22:36
@functionstackx functionstackx requested a review from a team as a code owner November 9, 2025 22:36
Copilot AI review requested due to automatic review settings November 9, 2025 22:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a race condition in the label validation workflow by removing the unlabeled trigger event, which was causing simultaneous workflow executions when users quickly unlabeled and relabeled PRs.

Key Changes:

  • Removed unlabeled from the workflow trigger types in the label validation workflow
  • Workflow now only triggers on labeled and synchronize events, requiring users to add a new label instead of removing and re-adding the same label to re-trigger validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@functionstackx functionstackx merged commit b7ba336 into main Nov 9, 2025
3 checks passed
@functionstackx functionstackx deleted the copilot/remove-pull-on-unlabel branch November 9, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants