Skip to content

Revert "Move pip install to dedicated GitHub Actions steps" #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
functionstackx merged 1 commit into from
Nov 10, 2025
Merged

Revert "Move pip install to dedicated GitHub Actions steps" #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .github/workflows/collect-results.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ jobs:
token: ${{ secrets.REPO_PAT }}
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install -q matplotlib

- name: Download JSON artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
Expand All @@ -49,7 +41,9 @@ jobs:
path: agg_${{ inputs.exp-name || 'all' }}.json

- name: Plot performance
run: python3 utils/plot_perf.py results/ ${{ inputs.exp-name || 'all' }}
run: |
pip install -q matplotlib
python3 utils/plot_perf.py results/ ${{ inputs.exp-name || 'all' }}
- name: Upload performance graphs
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
with:
Expand Down
20 changes: 4 additions & 16 deletions .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,9 @@ jobs:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install pydantic pyyaml

- id: get-jobs
run: |
pip install pydantic
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyyaml dependency is missing from the pip install command. The original code installed both pydantic and pyyaml, but after the revert only pydantic is being installed. This will cause failures if the generate_sweep_configs.py script requires the pyyaml package.

Suggested change
pip install pydantic
pip install pydantic pyyaml

Copilot uses AI. Check for mistakes.
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py ${{ inputs.generate-cli-command }})
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -77,20 +70,15 @@ jobs:
token: ${{ secrets.REPO_PAT }}
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install PyGithub

- name: Download results artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
path: ${{ env.RESULTS_DIR }}
pattern: results_*

- name: Install python dependencies
run: pip install PyGithub

- name: Calculate success rate
run: python3 utils/calc_success_rate.py $STATS_FILENAME

Expand Down
29 changes: 5 additions & 24 deletions .github/workflows/full-sweep-1k1k-scheduler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,9 @@ jobs:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install pydantic pyyaml

- id: get-dsr1-configs
run: |
pip install pydantic
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyyaml dependency is missing from the pip install command. The original code installed both pydantic and pyyaml, but after the revert only pydantic is being installed. This will cause failures if the generate_sweep_configs.py script requires the pyyaml package.

Copilot uses AI. Check for mistakes.
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 1k1k --model-prefix dsr1)
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT

Expand All @@ -35,16 +28,9 @@ jobs:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install pydantic pyyaml

- id: get-gptoss-configs
run: |
pip install pydantic
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyyaml dependency is missing from the pip install command. The original code installed both pydantic and pyyaml, but after the revert only pydantic is being installed. This will cause failures if the generate_sweep_configs.py script requires the pyyaml package.

Copilot uses AI. Check for mistakes.
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 1k1k --model-prefix gptoss)
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -173,20 +159,15 @@ jobs:
token: ${{ secrets.REPO_PAT }}
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install PyGithub

- name: Download results artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
path: ${{ env.RESULTS_DIR }}
pattern: results_*

- name: Install python dependencies
run: pip install PyGithub

- name: Calculate success rate
run: python3 utils/calc_success_rate.py $STATS_FILENAME

Expand Down
29 changes: 5 additions & 24 deletions .github/workflows/full-sweep-1k8k-scheduler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,9 @@ jobs:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install pydantic pyyaml

- id: get-dsr1-configs
run: |
pip install pydantic
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyyaml dependency is missing from the pip install command. The original code installed both pydantic and pyyaml, but after the revert only pydantic is being installed. This will cause failures if the generate_sweep_configs.py script requires the pyyaml package.

Copilot uses AI. Check for mistakes.
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 1k8k --model-prefix dsr1)
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT

Expand All @@ -35,16 +28,9 @@ jobs:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install pydantic pyyaml

- id: get-gptoss-configs
run: |
pip install pydantic
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyyaml dependency is missing from the pip install command. The original code installed both pydantic and pyyaml, but after the revert only pydantic is being installed. This will cause failures if the generate_sweep_configs.py script requires the pyyaml package.

Copilot uses AI. Check for mistakes.
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 1k8k --model-prefix gptoss)
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -128,20 +114,15 @@ jobs:
token: ${{ secrets.REPO_PAT }}
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install PyGithub

- name: Download results artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
path: ${{ env.RESULTS_DIR }}
pattern: results_*

- name: Install python dependencies
run: pip install PyGithub

- name: Calculate success rate
run: python3 utils/calc_success_rate.py $STATS_FILENAME

Expand Down
29 changes: 5 additions & 24 deletions .github/workflows/full-sweep-8k1k-scheduler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,9 @@ jobs:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install pydantic pyyaml

- id: get-dsr1-configs
run: |
pip install pydantic
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyyaml dependency is missing from the pip install command. The original code installed both pydantic and pyyaml, but after the revert only pydantic is being installed. This will cause failures if the generate_sweep_configs.py script requires the pyyaml package.

Copilot uses AI. Check for mistakes.
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 8k1k --model-prefix dsr1)
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT

Expand All @@ -35,16 +28,9 @@ jobs:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install pydantic pyyaml

- id: get-gptoss-configs
run: |
pip install pydantic
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyyaml dependency is missing from the pip install command. The original code installed both pydantic and pyyaml, but after the revert only pydantic is being installed. This will cause failures if the generate_sweep_configs.py script requires the pyyaml package.

Copilot uses AI. Check for mistakes.
CONFIG_JSON=$(python3 ${GITHUB_WORKSPACE}/utils/matrix-logic/generate_sweep_configs.py full-sweep --config-files ${GITHUB_WORKSPACE}/.github/configs/nvidia-master.yaml ${GITHUB_WORKSPACE}/.github/configs/amd-master.yaml --seq-lens 8k1k --model-prefix gptoss)
echo "search-space-config=$CONFIG_JSON" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -173,20 +159,15 @@ jobs:
token: ${{ secrets.REPO_PAT }}
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install PyGithub

- name: Download results artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
path: ${{ env.RESULTS_DIR }}
pattern: results_*

- name: Install python dependencies
run: pip install PyGithub

- name: Calculate success rate
run: python3 utils/calc_success_rate.py $STATS_FILENAME

Expand Down
20 changes: 4 additions & 16 deletions .github/workflows/full-sweep-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,11 @@ jobs:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install pydantic pyyaml

# This looks complicated, but it is just calling generate_sweep_configs.py conditioned on
# discrete inputs (i.e., run_1k1k, run_h100, etc.) to split the test sweep into discrete jobs
- id: generate-configs
run: |
pip install pydantic
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyyaml dependency is missing from the pip install command. The original code installed both pydantic and pyyaml, but after the revert only pydantic is being installed. This will cause failures if the generate_sweep_configs.py script requires the pyyaml package.

Suggested change
pip install pydantic
pip install pydantic pyyaml

Copilot uses AI. Check for mistakes.

set -x
# Build runner type filters based on inputs
Expand Down Expand Up @@ -434,20 +427,15 @@ jobs:
token: ${{ secrets.REPO_PAT }}
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install PyGithub

- name: Download results artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
path: ${{ env.RESULTS_DIR }}
pattern: results_*

- name: Install python dependencies
run: pip install PyGithub

- name: Calculate success rate
run: python3 utils/calc_success_rate.py $STATS_FILENAME

Expand Down
20 changes: 4 additions & 16 deletions .github/workflows/label-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,6 @@ jobs:
- name: Checkout code
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install pydantic pyyaml

- id: get-jobs
shell: python
run: |
Expand Down Expand Up @@ -57,6 +49,7 @@ jobs:
# Generate configs for standard labels
all_configs = []
if matching:
subprocess.run(['pip', 'install', 'pydantic'], check=True)
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyyaml dependency is missing from the pip install command. The original code installed both pydantic and pyyaml, but after the revert only pydantic is being installed. This will cause failures if the script requires the pyyaml package.

Suggested change
subprocess.run(['pip', 'install', 'pydantic'], check=True)
subprocess.run(['pip', 'install', 'pydantic', 'pyyaml'], check=True)

Copilot uses AI. Check for mistakes.

for label in matching:
result = subprocess.run([
Expand Down Expand Up @@ -132,20 +125,15 @@ jobs:
token: ${{ secrets.REPO_PAT }}
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.12'

- name: Install dependencies
run: pip install PyGithub

- name: Download results artifacts
uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
with:
path: ${{ env.RESULTS_DIR }}
pattern: results_*

- name: Install python dependencies
run: pip install PyGithub

- name: Calculate success rate
run: python3 utils/calc_success_rate.py $STATS_FILENAME

Expand Down