Skip to content

[AMD] exclude mia1-p01-g09 from AMD multi-node Slurm jobs #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seungrokj wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

[AMD] exclude mia1-p01-g09 from AMD multi-node Slurm jobs #2283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a0cee2
fix: exclude mia1-p01-g09 and mia1-p01-g14 from AMD multi-node Slurm …
seungrokj Jul 19, 2026
a0f6fc2
fix(submit): remove mia1-p01-g14 from SLURM exclude list
seungrokj Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/multi_node/amd_utils/submit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ fi
# Optional: exclude specific nodes (e.g. nodes with broken Docker sockets).
# Set SLURM_EXCLUDE_NODES env var to a comma-separated list of hostnames.
EXCLUDE_OPT=()
SLURM_EXCLUDE_NODES="${SLURM_EXCLUDE_NODES:-mia1-p01-g11,mia1-p01-g12,mia1-p01-g15}"
SLURM_EXCLUDE_NODES="${SLURM_EXCLUDE_NODES:-mia1-p01-g11,mia1-p01-g12,mia1-p01-g15,mia1-p01-g09}"
if [[ -n "${SLURM_EXCLUDE_NODES:-}" ]]; then
EXCLUDE_OPT=(--exclude "$SLURM_EXCLUDE_NODES")
fi
Comment on lines 166 to 172

@claude claude Bot Jul 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 This PR's title and description are English-only, but AGENTS.md mandates bilingual PR titles/descriptions (<English> / <中文标题> format plus a ## 中文说明 section). This is a pre-existing, repo-mandated documentation requirement unrelated to the actual code fix, which is correct.

Extended reasoning...

AGENTS.md (line 7) explicitly states: "PR and GitHub-issue titles & descriptions must be bilingual — include a Simplified Chinese version in addition to English. Title format: <English title> / <中文标题>. In the PR/issue body, follow the English content with its Chinese translation (e.g. a ## 中文说明 section mirroring the summary...)." This applies to every PR and every issue in the repository, per that same section.

This PR's title is "fix: exclude mia1-p01-g09 and mia1-p01-g14 from AMD multi-node Slurm jobs" — English only, with no / <中文标题> suffix. The PR body contains only ## Summary and ## Test plan sections in English; there is no accompanying ## 中文说明 section translating the summary into Simplified Chinese. Both requirements from AGENTS.md are unmet.

This is not a subjective style nit invented by the reviewer — it's an explicit, verifiable, repo-mandated checklist item that applies uniformly to all PRs, independent of the code change itself. The underlying code fix (adding mia1-p01-g09 and mia1-p01-g14 to the default SLURM_EXCLUDE_NODES list on line 169 of benchmarks/multi_node/amd_utils/submit.sh) is correct and not in question — the issue is purely with the PR metadata that accompanies it.

Step-by-step proof:

  1. Open AGENTS.md and read the callout on line 7: it requires <English title> / <中文标题> for the title, and a ## 中文说明 section (or equivalent trailing Chinese paragraph) in the body.
  2. Read this PR's actual title: "fix: exclude mia1-p01-g09 and mia1-p01-g14 from AMD multi-node Slurm jobs" — no / <中文标题> segment is present.
  3. Read this PR's actual body: it contains ## Summary (English bullet) and ## Test plan (English checklist) only — no ## 中文说明 or any Chinese text anywhere.
  4. Therefore the PR fails both the title-format and body-translation requirements mandated by AGENTS.md.

Impact and fix: There's no runtime or functional impact — the code change itself (excluding the two broken nodes from Slurm scheduling) is unaffected and correct. The fix is simply for the PR author to append / <中文标题> to the title (e.g. "fix: exclude mia1-p01-g09 and mia1-p01-g14 from AMD multi-node Slurm jobs / 修复:在 AMD 多节点 Slurm 任务中排除 mia1-p01-g09 和 mia1-p01-g14") and add a ## 中文说明 section mirroring the Summary/Test plan in Simplified Chinese before merging.

Expand Down