-
Notifications
You must be signed in to change notification settings - Fork 186
[NVIDIA] Enable GPTOSS GB200 DISAGG #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0de1704
gptoss test
a636eaf
update container
6fead87
typo fix
5ed73e4
update log dir name
f784686
test
0fb16c8
test
7bbda7f
typo
12094b2
typo1
8c7a9be
regex update
7153d95
regex update2
21c91ab
update regex 3
92c751a
enable all configs
e1e9475
test1
f877df1
reenable all configs
49b2a73
switch to dynamo release branch
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -20,8 +20,16 @@ else | |||||
| # Update the IMAGE variable to the squash file | ||||||
| export IMAGE=$SQUASH_FILE | ||||||
|
|
||||||
| export MODEL_PATH="/mnt/lustre01/models/deepseek-r1-0528-fp4-v2" | ||||||
| export SERVED_MODEL_NAME="deepseek-r1-fp4" | ||||||
| if [[ $MODEL == *"gpt-oss"* ]]; then | ||||||
| export MODEL_PATH="/mnt/lustre01/models/gpt-oss-120b" | ||||||
| export SERVED_MODEL_NAME="gpt-oss-120b" | ||||||
| elif [[ $MODEL == *"deepseek-r1-fp4" ]]; then | ||||||
| export MODEL_PATH="/mnt/lustre01/models/deepseek-r1-0528-fp4-v2" | ||||||
| export SERVED_MODEL_NAME="deepseek-r1-fp4" | ||||||
| else | ||||||
| echo "Unsupported model: $MODEL. Supported models are: gpt-oss, deepseek-r1-fp4" | ||||||
| exit 1 | ||||||
| fi | ||||||
| fi | ||||||
|
|
||||||
|
|
||||||
|
|
@@ -49,7 +57,11 @@ if [[ $FRAMEWORK == "dynamo-trtllm" ]]; then | |||||
| rm -rf "$DYNAMO_PATH" | ||||||
| git clone https://github.com/ai-dynamo/dynamo.git "$DYNAMO_PATH" | ||||||
| cd "$DYNAMO_PATH" | ||||||
| git checkout release/0.5.1-rc0.20251105 | ||||||
| if [[ $MODEL == *"gpt-oss"* ]]; then | ||||||
| git checkout jthomson04/gpt-oss-disagg-slurm | ||||||
| else | ||||||
| git checkout release/0.5.1-rc0.20251105 | ||||||
| fi | ||||||
| git submodule update --init --recursive | ||||||
|
|
||||||
| # Navigate to performance sweeps directory | ||||||
|
|
@@ -94,60 +106,82 @@ if [[ $FRAMEWORK == "dynamo-trtllm" ]]; then | |||||
| # gen_eplb_num_slots: Expert load balancing slots (0, 256, 288) | ||||||
| # gen_concurrency_list: Concurrency values (space-separated, quoted) | ||||||
|
|
||||||
| if [ "$isl" = "1024" ] && [ "$osl" = "1024" ]; then | ||||||
| if [ "$mtp_mode" = "on" ]; then | ||||||
| echo "Running 1k/1k MTP=ON configurations" | ||||||
| # MODEL-SPECIFIC HOOK: Different benchmark configurations for different models | ||||||
| if [[ $MODEL == *"gpt-oss"* ]]; then | ||||||
| # GPT-OSS specific benchmark configurations | ||||||
| if [ "$isl" = "8192" ] && [ "$osl" = "1024" ]; then | ||||||
|
|
||||||
|
||||||
Copilot
AI
Nov 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The find pattern 'ctx*gen*_batch_eplb*_mtp*' uses a generic wildcard () in the middle which may match unintended directory names. Consider using a more specific pattern like 'ctxgen*[td]ep*_batch*_eplb*_mtp*' or 'ctx*gen*{tp,tep,dep}_batch_eplb*_mtp*' to match only valid parallelism strategies (tp/tep/dep).
Suggested change
| RESULT_SUBDIRS=$(find "$LOGS_DIR" -name "ctx*_gen*_*_batch*_eplb*_mtp*" -type d) | |
| RESULT_SUBDIRS=$(find "$LOGS_DIR" -name "ctx*_gen*_{tp,tep,dep}_batch*_eplb*_mtp*" -type d) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Inconsistent comment formatting. The DeepSeek comment on line 93 uses '# DSR1' while this uses '# GPTOSS' with different indentation. Align the comment indentation with line 93 for consistency.