S3 part upload retries#25
Open
amanda-ruby wants to merge 2 commits intoSendSafely:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In testing the upload of large files (>= 30 GB) I noticed that the chunk upload to S3 would have a "Connection reset by peer" error for one of the (many, many) parts, scuttling the upload.
This pull request enhances the reliability of S3 file part uploads in the
sendsafely/utilities.pymodule by adding retry logic with exponential backoff. This change helps handle transient network errors more gracefully, reducing the chance of upload failures due to temporary issues.Improvements to S3 upload reliability:
_upload_file_part_to_s3, retrying up to 5 times with increasing delays (up to 180 seconds) on connection errors, timeouts, or chunked encoding errors. This also includes user feedback viasys.stdouton each retry attempt.Dependency updates:
sysandtimemodules to support the new retry and logging functionality.