Lint readme update (#4)

* refactor(async naming conventions): Added some missing 'async' postfix to some methods

* docs(readme.md): Mentioned NYC as prerequisit in the readme as it is required to run unit tests

Author: gallayl

README.md

@@ -12,8 +12,9 @@ This package is under development and not released yet.
 
 ## Installation
 ### Prerequisites
-* Node.JS ^6.1.0
-* NPM ^4.0.0
+* [Node.JS](https://nodejs.org) ^6.1.0
+* [NPM](https://www.npmjs.com) ^4.0.0
+* [NYC](https://www.npmjs.com/package/nyc) for running tests
 
 You can get the latest version with NPM
 

src/sn-fetch-types.ts

@@ -26,7 +26,7 @@ export async function DoFetchTypes(initializer: Initializer = Initializer.Curren
         await initializer.Stage.CallGulpRunAsync('tsc', initializer.Stage.TempFolderPath);
         await initializer.Stage.CallGulpRunAsync('nyc mocha -p tsconfig.json dist/test/index.js', initializer.Stage.TempFolderPath);
         await initializer.Stage.UpdateModuleAsync();
-        await initializer.Stage.Cleanup();
+        await initializer.Stage.CleanupAsync();
 
         console.log('All done.');
     } catch (error) {

src/utils/ask.ts

@@ -62,7 +62,9 @@ export class Ask {
     public static async MissingConfigs<K extends keyof SnConfigModel>(...missingConfigs: K[]): Promise<Partial<SnConfigModel>> {
         return new Promise<Partial<SnConfigModel>>((resolve, reject) => {
             Prompt.start();
-            const configs = missingConfigs.map(this.createPromptQuestionFromConfigName);
+            const configs = missingConfigs.map((cfg) => {
+                this.createPromptQuestionFromConfigName(cfg);
+            });
             Prompt.get(configs, (err, res) => {
                 resolve();
             });

src/utils/download.ts

@@ -51,7 +51,7 @@ export class Download {
      * Executes the download request, flatterns the data into a simple in-memory buffer
      * @returns {Promise<Buffer>} An awaitable promise with the in-memory buffer
      */
-    public GetAsBufferAsync(): Promise<Buffer> {
+    public async GetAsBufferAsync(): Promise<Buffer> {
         return new Promise<Buffer>((resolve) => {
             Http.get({
                 headers: this.headers,

src/utils/stage.ts

@@ -42,7 +42,7 @@ export class Stage {
      * - Copies the existing Typescript source files and testss
      */
     public async PrepareAsync() {
-        this.Cleanup();
+        await this.CleanupAsync();
         const task = Gulp.src([
             `./src/**/*.ts`,
             `./test/**/*.ts`,
@@ -67,7 +67,7 @@ export class Stage {
                 cwd: this.TempFolderPath,
             })
             .pipe(Gulp.dest(this.paths.SnClientPath));
-        await task.resume();
+        return await task.resume();
     }
 
     public async InitializeConfigAsync() {
@@ -99,7 +99,14 @@ export class Stage {
     /**
      * Cleans up (deletes) the specified temporary folder
      */
-    public Cleanup() {
-        Delete.sync(this.TempFolderPath, { force: true });
+    public async CleanupAsync() {
+        return new Promise((resolve, reject) => {
+            try {
+                Delete.sync(this.TempFolderPath, { force: true });
+                resolve();
+            } catch (error) {
+                reject(error);
+            }
+        });
     }
 }