Skip to content

perf: cache plan-nodes query (provider-scoped, 15s TTL) to fix add-nodes delay #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sentinel-Bluebuilder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: cache plan-nodes query (provider-scoped, 15s TTL) to fix add-nodes delay #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,24 @@ async function _getPlanStatsImpl(planId) {
};
}

// Cached wrapper around the (expensive) plan-nodes query. The impl does an RPC
// QueryNodesForPlan PLUS a per-member rpcQueryLeasesForNode fan-out, so re-running
// it on every Add-Nodes keystroke / filter / post-link refetch was the root of the
// "big delay before added nodes show" symptom. Scope the key by provider because the
// per-node lease lookup picks OUR lease (prov_address === getProvAddr()). Short TTL
// (15s) keeps it fresh; link/unlink success paths invalidate it explicitly so a
// just-added node is reflected on the very next refetch (subject to chain indexing).
function invalidatePlanNodes(planId) {
const prov = getProvAddr() || '_anon';
cacheInvalidate(`planNodes:${planId}:${prov}`);
}

async function getNodesForPlan(planId) {
const prov = getProvAddr() || '_anon';
return cached(`planNodes:${planId}:${prov}`, 15_000, () => _getNodesForPlanImpl(planId));
}

async function _getNodesForPlanImpl(planId) {
const nodes = [];

// RPC-first
Expand Down Expand Up @@ -3415,6 +3432,9 @@ app.post('/api/plan-manager/link', async (req, res) => {

const ownErr = await assertPlanOwnership(planIdNum);
if (ownErr) return res.status(ownErr.status).json({ error: ownErr.error });
// Drop the cached plan-nodes snapshot so the next /api/all-nodes refetch
// re-queries chain truth instead of serving a pre-link cache (TTL 15s).
invalidatePlanNodes(planIdNum);

const linkMsg = {
typeUrl: C.MSG_LINK_TYPE,
Expand Down Expand Up @@ -3556,6 +3576,7 @@ app.post('/api/plan-manager/batch-link', async (req, res) => {
const ownErr = await assertPlanOwnership(planIdNum);
if (ownErr) return res.status(ownErr.status).json({ error: ownErr.error });
const hours = parseInt(reqLeaseHours) || 24;
invalidatePlanNodes(planIdNum);
console.log(`\n[BATCH-LINK] ${addrs.length} nodes → plan ${planId} (lease: ${hours}h)`);


Expand Down Expand Up @@ -3644,6 +3665,7 @@ app.post('/api/plan-manager/unlink', async (req, res) => {

const ownErr = await assertPlanOwnership(planIdNum);
if (ownErr) return res.status(ownErr.status).json({ error: ownErr.error });
invalidatePlanNodes(planIdNum);

const msg = {
typeUrl: C.MSG_UNLINK_TYPE,
Expand Down Expand Up @@ -3694,6 +3716,7 @@ app.post('/api/plan-manager/batch-unlink', async (req, res) => {
if (badAddr) return res.status(400).json({ error: `invalid node address: ${badAddr}` });
const ownErr = await assertPlanOwnership(planIdNum);
if (ownErr) return res.status(ownErr.status).json({ error: ownErr.error });
invalidatePlanNodes(planIdNum);
console.log(`\n[BATCH-UNLINK] ${addrs.length} nodes from plan ${planId}`);

const msgs = addrs.map(addr => ({
Expand Down