security: harden s1-secops MCP server and monitor plugins#73
Merged
jham-s1 merged 3 commits intoJul 7, 2026
Merged
Conversation
…tall RCE Addresses three triaged High findings against ai-siem (Mythos GUIDs 019eff58, 019eff5a, 019eff60). MCP server (mcp/s1-secops-mcp), synced from claude-skills master: - s1.js: add safeUrl() — require a single leading '/' and pin the resolved origin to the configured console, so an LLM-supplied path can no longer redirect the request (and the tenant ApiToken) to an attacker host (@evil / .evil / //evil / backslash variants). Applied to all five verbs. - mgmt-console.js: add ^/web/api/v2.1/ pattern to each s1_api_* path schema. - http-transport.js: in no-auth mode, reject any browser Origin and validate the Host header (DNS-rebind guard). Auth/proxy path unchanged. - tests: add ssrf-path and http-origin-guard suites (34/34 pass). Monitors (monitors/): - maxmind.py, powerquerymonitor.py: remove runtime 'pip install' from _initialize() (ran as root on every agent restart; CWE-494/829). - log_gen.py: delete dead install_dependencies() helper. - add pinned requirements.txt; README instructs a one-time hash-verified install.
pmoses-s1
changed the title
jham-s1
approved these changes
Jul 7, 2026
jham-s1
left a comment
jham-s1
left a comment
Contributor
There was a problem hiding this comment.
Just helping out and approving this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security hardening for the s1-secops MCP server and the Scalyr monitor plugins, plus a small README update.
Changes
mcp/s1-secops-mcp/lib/s1.js— validate and origin-pin the API path across all verbs.mcp/s1-secops-mcp/tools/mgmt-console.js— constrain thes1_api_*path schema.mcp/s1-secops-mcp/lib/http-transport.js— add Origin/Host validation in no-auth mode.monitors/— remove runtimepip install; add pinnedrequirements.txt; README updated.README.md— add a SentinelOne SecOps skills section (8 skills).Tests
cd mcp/s1-secops-mcp && npm test→ 34/34 pass.