Accept true as 'add' and false as 'strip' for options.builtinsPrefix

Author: Septh

README.md

@@ -91,7 +91,7 @@ export default {
       builtins?: boolean
 
       // node: prefix handing for importing NodeJS builtins. Default: 'add'.
-      builtinsPrefix?: 'add' | 'strip' | 'ignore'
+      builtinsPrefix?: boolean | 'add' | 'strip' | 'ignore'
 
       // The path(s) to your package.json. Default: read below.
       packagePath?: string | string[]
@@ -121,10 +121,10 @@ export default {
 #### builtins?: boolean = true
 Set the `builtins` option to `false` if you'd like to use some shims/polyfills for those. You'll most certainly need [an other plugin](https://www.npmjs.com/package/rollup-plugin-node-polyfills) as well.
 
-#### builtinsPrefix?: 'add' | 'strip' | 'ignore' = 'add'
+#### builtinsPrefix?: boolean | 'add' | 'strip' | 'ignore' = 'add'
 How to handle the `node:` scheme when importing builtins (i.e., `import path from 'node:path'`).
-- If `add` (the default, recommended), the `node:` scheme is always added if missing, so `path` becomes `node:path`. In effect, this dedupes your imports of Node builtins by homogenizing their names to their schemed version.
-- If `strip`, the scheme is always removed, so `node:path` becomes `path`. In effect, this dedupes your imports of Node builtins by homogenizing their names to their scheme-less version. Schemed-only builtins like `node:test` or `node:sqlite` are never stripped.
+- If `add` or `true` (the default, recommended), the `node:` scheme is always added if missing, so `path` becomes `node:path`. In effect, this dedupes your imports of Node builtins by homogenizing their names to their schemed version.
+- If `strip` or `false`, the scheme is always removed, so `node:path` becomes `path`. In effect, this dedupes your imports of Node builtins by homogenizing their names to their scheme-less version. Schemed-only builtins like `node:test` or `node:sqlite` are never stripped.
 - `ignore` will simply leave all builtins imports as written in your code. Caveat: if you write `node:path` but one of your bundled dependencies uses `path` (or the other way around), your bundle will end up with both `node:path` and `path` imports.
 
 >[!NOTE]

source/index.ts

@@ -28,7 +28,7 @@ export interface ExternalsOptions {
      *
      * Defaults to `'add'`.
      */
-    builtinsPrefix?: 'add' | 'strip' | 'ignore'
+    builtinsPrefix?: boolean | 'add' | 'strip' | 'ignore'
 
     /**
      * Path/to/your/package.json file (or array of paths).
@@ -208,9 +208,9 @@ function nodeExternals(options: ExternalsOptions = {}): Plugin {
                     continue
 
                 case 'builtinsPrefix':
-                    if (value === 'add')
+                    if (value === 'add' || value === true)
                         config.prefix = true
-                    else if (value === 'strip')
+                    else if (value === 'strip' || value === false)
                         config.prefix = false
                     else if (value === 'ignore')
                         config.prefix = null

test/builtins.test.ts

@@ -19,13 +19,22 @@ test("Does NOT mark Node builtins external when builtins=false", async t => {
     }
 })
 
-test("Does NOT mark Node builtins external when implicitly excluded", async t => {
-    const context = await initPlugin({ exclude: [ 'path', 'node:fs' ]})
+test("Does NOT mark Node builtins external when builtins=true and implicitly excluded", async t => {
+    const context = await initPlugin({ builtins: true, exclude: [ 'path', 'node:fs' ]})
+
+    // Implicitly excluded
     for (const builtin of [ 'path', 'node:fs' ]) {
         t.like(await context.resolveId(builtin, 'index.js'), {
             external: false
         })
     }
+
+    // not excluded
+    for (const builtin of [ 'node:module' ]) {
+        t.like(await context.resolveId(builtin, 'index.js'), {
+            external: true
+        })
+    }
 })
 
 test("Marks Node builtins external when builtins=false and implicitly included", async t => {
@@ -46,7 +55,25 @@ test("Adds 'node:' prefix to builtins by default", async t => {
     }
 })
 
-test("Removes 'node:' prefix when using builtinsPrefix='strip'", async t => {
+test("Adds 'node:' prefix when builtinsPrefix is 'add'", async t => {
+    const context = await initPlugin({ builtinsPrefix: 'add' })
+    for (const builtin of [ 'node:path', 'path' ]) {
+        t.like(await context.resolveId(builtin, 'index.js'), {
+            id: 'node:path'
+        })
+    }
+})
+
+test("Adds 'node:' prefix when builtinsPrefix is true", async t => {
+    const context = await initPlugin({ builtinsPrefix: true })
+    for (const builtin of [ 'node:path', 'path' ]) {
+        t.like(await context.resolveId(builtin, 'index.js'), {
+            id: 'node:path'
+        })
+    }
+})
+
+test("Removes 'node:' prefix when builtinsPrefix is 'strip'", async t => {
     const context = await initPlugin({ builtinsPrefix: 'strip' })
     for (const builtin of [ 'node:path', 'path' ]) {
         t.like(await context.resolveId(builtin, 'index.js'), {
@@ -55,18 +82,29 @@ test("Removes 'node:' prefix when using builtinsPrefix='strip'", async t => {
     }
 })
 
-test("Does NOT remove 'node:test' prefix even with builtinsPrefix='strip'", async t => {
+test("Removes 'node:' prefix when builtinsPrefix is false", async t => {
+    const context = await initPlugin({ builtinsPrefix: false })
+    for (const builtin of [ 'node:path', 'path' ]) {
+        t.like(await context.resolveId(builtin, 'index.js'), {
+            id: 'path'
+        })
+    }
+})
+
+test("Does NOT remove 'node:' prefix on prefixed-only builtins even with builtinsPrefix='strip'", async t => {
     const context = await initPlugin({ builtinsPrefix: 'strip' })
-    for (const builtin of [ 'node:test' ]) {
+    for (const builtin of [ 'node:test', 'node:sqlite', 'node:sea' ]) {
         t.like(await context.resolveId(builtin, 'index.js'), {
             id: builtin
         })
     }
 })
 
-test("Does not recognize 'test' as a Node builtin", async t => {
+test("Does not recognize unprefixed 'test' / 'sqlite' / 'sea' as a Node builtins", async t => {
     const context = await initPlugin()
-    t.is(await context.resolveId('node', 'index.js'), IGNORED)
+    t.is(await context.resolveId('node',   'index.js'), IGNORED)
+    t.is(await context.resolveId('sqlite', 'index.js'), IGNORED)
+    t.is(await context.resolveId('sea',    'index.js'), IGNORED)
 })
 
 test("Ignores 'node:' prefix when using builtinsPrefix='ignore'", async t => {