Allow third-party logger-like objects in set_logger (#688) (#726)

* fix(logger): accept logger-like objects with log(level, message) method (#688)

* test(firefox): make cache os_type matrix platform-aware to avoid cross-OS network flakiness

Author: aleksandr-kotlyar

tests/test_custom_logger.py

@@ -39,3 +39,23 @@ def test_custom_logger(capsys, create_logger):
 
     # Restore the old logger
     set_logger(__old_logger)
+
+
+def test_custom_logger_accepts_logger_like_object():
+    records = []
+
+    class LoggerLike:
+        def log(self, level, message):
+            records.append((level, message))
+
+    logger_like = LoggerLike()
+    set_logger(logger_like)
+
+    log_msg = "logger-like object message"
+    log(log_msg)
+
+    assert records
+    assert records[-1][1] == log_msg
+
+    # Restore the old logger
+    set_logger(__old_logger)

tests/test_firefox_manager.py

@@ -1,4 +1,5 @@
 import os
+import platform
 
 import pytest
 from selenium import webdriver
@@ -64,7 +65,15 @@ def test_can_download_ff_x64(delete_drivers_dir):
     assert os.path.exists(driver_path)
 
 
-@pytest.mark.parametrize('os_type', ['win32', 'win64', 'linux32', 'linux64'])
+def _cache_os_types_for_current_platform():
+    if platform.system().lower().startswith("win"):
+        return ["win32", "win64"]
+    if platform.system().lower().startswith("linux"):
+        return ["linux32", "linux64"]
+    return ["mac64"]
+
+
+@pytest.mark.parametrize('os_type', _cache_os_types_for_current_platform())
 @requires_gh_token
 def test_can_get_driver_from_cache(os_type):
     GeckoDriverManager(os_system_manager=OperationSystemManager(os_type)).install()

webdriver_manager/core/logger.py

@@ -17,15 +17,14 @@ def set_logger(logger):
 
     Parameters
     ----------
-    logger : logging.Logger
-        The custom logger to use.
+    logger : object
+        Any logger-like object that provides a callable ``log(level, message)`` method.
 
     Returns None
     """
 
-    # Check if the logger is a valid logger
-    if not isinstance(logger, logging.Logger):
-        raise ValueError("The logger must be an instance of logging.Logger")
+    if not callable(getattr(logger, "log", None)):
+        raise ValueError("The logger must provide a callable log(level, message) method")
 
     # Bind the logger input to the global logger
     global __logger