Reduce repeated HTTP requests by caching resolved driver version (#656) (#721)

* fix(cache): cache resolved driver version to avoid repeated metadata requests

Author: aleksandr-kotlyar

tests/test_driver_cache_request_dedup.py

@@ -0,0 +1,39 @@
+from webdriver_manager.core.driver_cache import DriverCacheManager
+
+
+class OSMock:
+    def get_os_type(self):
+        return "linux64"
+
+    def get_browser_version_from_os(self, _browser_type=None):
+        return "120.0.6099.71"
+
+
+class DriverMock:
+    def __init__(self):
+        self.version_calls = 0
+
+    def get_name(self):
+        return "chromedriver"
+
+    def get_browser_type(self):
+        return "google-chrome"
+
+    def get_browser_version_from_os(self):
+        return "120.0.6099.71"
+
+    def get_driver_version_to_download(self):
+        self.version_calls += 1
+        return "120.0.6099.109"
+
+
+def test_driver_version_lookup_is_cached_within_cache_manager(tmp_path):
+    cache = DriverCacheManager(root_dir=str(tmp_path), os_system_manager=OSMock())
+    driver = DriverMock()
+
+    cache.get_cache_key_driver_version(driver)
+    cache.get_cache_key_driver_version(driver)
+    cache._DriverCacheManager__get_path(driver)
+    cache._DriverCacheManager__get_metadata_key(driver)
+
+    assert driver.version_calls == 1

webdriver_manager/core/driver_cache.py

@@ -194,14 +194,15 @@ def __get_metadata_key(self, driver: Driver):
     def get_cache_key_driver_version(self, driver: Driver):
         if self._cache_key_driver_version:
             return self._cache_key_driver_version
-        return driver.get_driver_version_to_download()
+        self._cache_key_driver_version = driver.get_driver_version_to_download()
+        return self._cache_key_driver_version
 
     def __get_path(self, driver: Driver):
         if self._driver_binary_path is None:
             self._driver_binary_path = os.path.join(
                 self._drivers_directory,
                 driver.get_name(),
                 self.get_os_type(),
-                driver.get_driver_version_to_download(),
+                self.get_cache_key_driver_version(driver),
             )
         return self._driver_binary_path