Fix buffer overflow lib selection logic for Windows 7 targets#40
Merged
SergiusTheBest merged 2 commits intoSergiusTheBest:masterfrom Apr 28, 2026
Merged
Conversation
Owner
|
@Anion3r Thank you for the PR! Let me check it. |
Narrow buffer overflow library selection logic
Owner
|
@Anion3r Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject : Fix: Incorrect BufferOverflow library selection for Windows 7 targets
Problem: > When using WDK 10 to target Windows 7 (WINVER 0x0601), FindWDK incorrectly links against BufferOverflowFastFailK.lib if it exists. This causes a BSOD (Bugcheck 0 / STATUS_BREAKPOINT) on Windows 7 because it does not support the FastFail instruction introduced in Windows 8.
Solution:
Changed the logic to select the buffer overflow library based on the target WDK_WINVER.
If WDK_WINVER < 0x0602 (Win8), it now explicitly prefers BufferOverflowK.lib.
This aligns with official Microsoft documentation Building Drivers for Different Versions of Windows regarding driver compatibility for older Windows versions.