Rerewrite des Registries en final#1318
Merged
Merged
Conversation
iambibi
added
the
🧹Rewrite
Member
Author
|
j'attends les 2 nouveaux registres, pour les mettre en final et adapter la structure avec les ItemMenuBuilder et les KeyedRegistry |
Member
Author
|
peut cependant déjà etre review |
# Conflicts: # src/main/java/fr/openmc/core/OMCRegistry.java # src/main/java/fr/openmc/core/features/homes/menu/HomeUpgradeMenu.java # src/main/java/fr/openmc/core/registry/enchantments/CustomEnchantmentRegistry.java # src/main/java/fr/openmc/core/registry/items/CustomItemRegistry.java # src/main/java/fr/openmc/core/registry/mobs/CustomMobRegistry.java
…stry # Conflicts: # src/main/java/fr/openmc/api/menulib/template/ConfirmMenu.java # src/main/java/fr/openmc/api/menulib/utils/ItemMenuBuilder.java # src/main/java/fr/openmc/core/OMCRegistry.java # src/main/java/fr/openmc/core/features/adminshop/menus/AdminShopCategoryMenu.java # src/main/java/fr/openmc/core/features/adminshop/menus/ColorVariantsMenu.java # src/main/java/fr/openmc/core/features/adminshop/menus/ConfirmMenu.java # src/main/java/fr/openmc/core/features/adminshop/menus/LeavesVariantsMenu.java # src/main/java/fr/openmc/core/features/adminshop/menus/LogVariantsMenu.java # src/main/java/fr/openmc/core/features/city/menu/CityChestMenu.java # src/main/java/fr/openmc/core/features/city/menu/CityPermsMenu.java # src/main/java/fr/openmc/core/features/city/menu/CityTransferMenu.java # src/main/java/fr/openmc/core/features/city/menu/InvitationsMenu.java # src/main/java/fr/openmc/core/features/city/menu/list/CityListDetailsMenu.java # src/main/java/fr/openmc/core/features/city/menu/list/CityListMenu.java # src/main/java/fr/openmc/core/features/city/menu/list/CityPlayerListMenu.java # src/main/java/fr/openmc/core/features/city/menu/playerlist/CityPlayerListMenu.java # src/main/java/fr/openmc/core/features/city/sub/mayor/menu/MayorVoteMenu.java # src/main/java/fr/openmc/core/features/city/sub/mayor/menu/create/PerkChoiceMenu.java # src/main/java/fr/openmc/core/features/city/sub/milestone/menu/LevelMilestoneMenu.java # src/main/java/fr/openmc/core/features/city/sub/rank/menus/CityRankDetailsMenu.java # src/main/java/fr/openmc/core/features/city/sub/rank/menus/CityRankIconMenu.java # src/main/java/fr/openmc/core/features/city/sub/rank/menus/CityRankMemberMenu.java # src/main/java/fr/openmc/core/features/city/sub/rank/menus/CityRankPermsMenu.java # src/main/java/fr/openmc/core/features/city/sub/rank/menus/CityRanksMenu.java # src/main/java/fr/openmc/core/features/city/sub/war/menu/main/MainWarMenu.java # src/main/java/fr/openmc/core/features/city/sub/war/menu/main/WarPlayerListMenu.java # src/main/java/fr/openmc/core/features/city/sub/war/menu/selection/WarChooseParticipantsMenu.java # src/main/java/fr/openmc/core/features/city/sub/war/menu/selection/WarChooseSizeMenu.java # src/main/java/fr/openmc/core/features/credits/CreditsMenu.java # src/main/java/fr/openmc/core/features/economy/menu/TransactionsMenu.java # src/main/java/fr/openmc/core/features/events/commands/calendar/CalendarMenu.java # src/main/java/fr/openmc/core/features/events/contents/weeklyevents/contents/contest/menu/ContributionMenu.java # src/main/java/fr/openmc/core/features/homes/menu/HomeChangeIconMenu.java # src/main/java/fr/openmc/core/features/homes/menu/HomeConfigMenu.java # src/main/java/fr/openmc/core/features/homes/menu/HomeMenu.java # src/main/java/fr/openmc/core/features/homes/menu/HomeUpgradeMenu.java # src/main/java/fr/openmc/core/features/mailboxes/menu/HomeMailbox.java # src/main/java/fr/openmc/core/features/mailboxes/menu/letter/LetterMenu.java # src/main/java/fr/openmc/core/features/mailboxes/menu/letter/SendingLetter.java # src/main/java/fr/openmc/core/features/mailboxes/utils/MailboxMenuManager.java # src/main/java/fr/openmc/core/features/quests/menus/QuestsMenu.java # src/main/java/fr/openmc/core/features/settings/menu/PlayerSettingsMenu.java # src/main/java/fr/openmc/core/features/tickets/menus/MachineBallsOpenMenu.java
…re is a by default lore and display name to back button
Member
Author
|
j'aurais plus qu'a testé le spawn des mobs, et tt |
iambibi
added
the
🔥Urgent
7 tasks
Member
Author
|
ready for review |
Member
Author
|
ça serait vraiment cool si ça peut etre passée |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR:
Acces plus simple au ressources
ex
avant OMCRegistry.CUSTOM_ITEMS.get("omc_items:aywenite")
apres OMCRegistry.CUSTOM_ITEMS.AYWENITE
ça compte pour tout les registres
Étape nécessaire afin que la PR soit fini (si PR en draft)
Decrivez vos changements