Commit 4b96e87
fix(runtime): inject CPU/memory/port defaults; skip endpoints on --no-wait; silence SDK validation warnings
Three problems surfaced when running the README's minimal example
`ar runtime apply -f runtime.yaml`:
1. HTTP 400 "CPU is required; Memory is required; Port is required"
The CLI passed cpu=null/memory=null/port=null through to the SDK
even though the docs already promised default 2 cores / 4096 MB /
9000. Defaults were never actually applied.
Add DEFAULT_CPU / DEFAULT_MEMORY_MB / DEFAULT_PORT in
runtime_constants and inject them in to_runtime_create_input /
to_runtime_update_input. `spec.container.port` keeps its documented
precedence over `spec.port`, both fall back to DEFAULT_PORT.
2. HTTP 400 "runtime must be in READY status to create endpoints"
under --no-wait
apply_cmd unconditionally called reconcile_endpoints after
reconcile_runtime — fine under --wait (we'd already polled runtime
to READY), but under --no-wait the runtime is still CREATING and the
backend rejects endpoint create.
Gate reconcile_endpoints + poll_many_parallel on `wait`. Under
--no-wait we just submit the runtime; an interactive run prints a
stderr notice telling the user to re-apply once the runtime is
READY (TTY-only so it doesn't pollute scripted JSON output).
3. SDK pydantic warning spam
Every `list_all()` call deserializes every runtime in the workspace,
and the SDK emits "validate type failed" WARNINGs whenever a
server-side record doesn't match its current schema (other people's
runtimes with codeConfiguration.language=java17, empty
logConfiguration, etc.). A single apply emitted ~10 lines of noise.
Install a logging.Filter on the `agentrun-logger` logger that drops
exactly the "validate type failed" message. `--debug` removes the
filter so debugging shows full logs.
Docs:
- runtime.md (en + zh) apply Options table: document the new --no-wait
semantics; add a paragraph explaining the auto-injected resource
defaults.
Tests:
- test_create_input_user_values_override_defaults — explicit values win.
- test_create_input_container_port_wins_over_spec_port — precedence.
- test_update_input_applies_same_defaults — symmetry with create.
- Existing test_create_input_injects_system_tag_and_container_artifact
now also asserts cpu=2.0 / memory=4096 / port=9000.
- test_apply_create_happy_path tightened: under --no-wait,
create_endpoint MUST NOT be called and endpoints list must be empty.
- test_apply_update_path tightened: under --wait, create_endpoint IS
called after the runtime reaches READY.
Local gate: ruff + mypy clean, 525/525 tests pass, coverage 95.25%.
Signed-off-by: Sodawyx <sodawyx@126.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Sodawyx <sodawyx@126.com>1 parent 009807b commit 4b96e87
8 files changed
Lines changed: 119 additions & 17 deletions
File tree
- docs
- en
- zh
- src/agentrun_cli
- _utils
- commands/runtime
- tests
- integration
- unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
50 | 54 | | |
51 | 55 | | |
52 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
48 | 51 | | |
49 | 52 | | |
50 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
17 | 24 | | |
18 | 25 | | |
19 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
119 | 122 | | |
120 | 123 | | |
121 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
122 | 135 | | |
123 | 136 | | |
124 | 137 | | |
| |||
129 | 142 | | |
130 | 143 | | |
131 | 144 | | |
132 | | - | |
133 | | - | |
134 | | - | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
135 | 148 | | |
136 | 149 | | |
137 | 150 | | |
| |||
157 | 170 | | |
158 | 171 | | |
159 | 172 | | |
160 | | - | |
161 | | - | |
162 | | - | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
163 | 176 | | |
164 | 177 | | |
165 | 178 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| 119 | + | |
119 | 120 | | |
120 | 121 | | |
121 | 122 | | |
122 | 123 | | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
126 | 139 | | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | 140 | | |
135 | 141 | | |
136 | 142 | | |
| |||
143 | 149 | | |
144 | 150 | | |
145 | 151 | | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
146 | 158 | | |
147 | 159 | | |
148 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
29 | 48 | | |
30 | 49 | | |
31 | 50 | | |
| |||
95 | 114 | | |
96 | 115 | | |
97 | 116 | | |
98 | | - | |
99 | | - | |
100 | 117 | | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
101 | 124 | | |
102 | 125 | | |
103 | 126 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
177 | 181 | | |
178 | 182 | | |
179 | 183 | | |
| |||
205 | 209 | | |
206 | 210 | | |
207 | 211 | | |
| 212 | + | |
| 213 | + | |
208 | 214 | | |
209 | 215 | | |
210 | 216 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
56 | 90 | | |
57 | 91 | | |
58 | 92 | | |
| |||
0 commit comments