Commit 2593f3f
committed
Align reasoning e2e with protocol passthrough
The protocol handlers now surface reasoning_content when the model output contains it, independent of MODEL_PARAMETER_RULES. Keep the e2e contract aligned with that behavior so the false thinking flag case verifies passthrough instead of suppression.
Constraint: Requirement moved env thinking control to model invocation, while protocol conversion follows actual returned reasoning_content.
Rejected: Restore protocol-level env gating | It would contradict the current reasoning_content passthrough requirement.
Confidence: high
Scope-risk: narrow
Directive: Do not reintroduce protocol-level MODEL_PARAMETER_RULES gating for reasoning_content without a new product decision.
Tested: uv sync --python 3.10 --dev --all-extras; uv run --python 3.10 pytest tests/e2e/test_reasoning_protocol.py -q; git diff --check
Change-Id: I806b351980a716b4e0395414b0896ddd603747bc
Not-tested: Full cloud-backed e2e suite locally; waiting for GitHub Actions E2E.1 parent 5f0d6b2 commit 2593f3f
1 file changed
Lines changed: 7 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | | - | |
| 74 | + | |
76 | 75 | | |
77 | 76 | | |
78 | 77 | | |
79 | 78 | | |
80 | 79 | | |
81 | | - | |
| 80 | + | |
82 | 81 | | |
83 | 82 | | |
84 | 83 | | |
| |||
104 | 103 | | |
105 | 104 | | |
106 | 105 | | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
| 106 | + | |
111 | 107 | | |
112 | 108 | | |
113 | 109 | | |
| |||
140 | 136 | | |
141 | 137 | | |
142 | 138 | | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
0 commit comments