Deprecate snake-case service aliases, modernize README

The snake_case service IDs (setono_gls_webservice.client and
setono_gls_webservice.factory.soap_client) are now aliases marked deprecated
since 1.4 in favour of the FQCN interfaces. README usage examples updated
to PHP 8 constructor promotion and PHP service config DSL.

Author: loevgaard

README.md

@@ -44,28 +44,27 @@ use Setono\GLS\Webservice\Client\ClientInterface;
 
 final class YourService
 {
-    private $client;
-    
-    public function __construct(ClientInterface $client)
+    public function __construct(private readonly ClientInterface $client)
     {
-        $this->client = $client;
     }
 }
 ```
 
-With auto wiring this will work out of the box. If you're not using auto wiring you have to inject it in your service definition:
+With autowiring this will work out of the box. If you're not using autowiring you have to inject it in your service definition:
 
-```xml
-<?xml version="1.0" encoding="UTF-8" ?>
+```php
+<?php
+
+use Setono\GLS\Webservice\Client\ClientInterface;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 
-<container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
-    <services>
-        <service id="YourService">
-            <argument type="service" id="Setono\GLS\Webservice\Client\ClientInterface"/>
-        </service>
-    </services>
-</container>
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
 
+return static function (ContainerConfigurator $container): void {
+    $container->services()
+        ->set(YourService::class)
+        ->args([service(ClientInterface::class)]);
+};
 ```
 
 [ico-version]: https://poser.pugx.org/setono/gls-webservice-bundle/v/stable

src/Resources/config/services.php

@@ -12,16 +12,20 @@
 return static function (ContainerConfigurator $container): void {
     $services = $container->services();
 
-    $services->set('setono_gls_webservice.factory.soap_client', SoapClientFactory::class)
+    $services->set(SoapClientFactory::class)
         ->args([
             param('setono_gls_webservice.wsdl'),
             param('setono_gls_webservice.options'),
         ]);
 
-    $services->alias(SoapClientFactoryInterface::class, 'setono_gls_webservice.factory.soap_client');
+    $services->alias(SoapClientFactoryInterface::class, SoapClientFactory::class);
+    $services->alias('setono_gls_webservice.factory.soap_client', SoapClientFactoryInterface::class)
+        ->deprecate('setono/gls-webservice-bundle', '1.4', 'The "%alias_id%" service alias is deprecated. Use "' . SoapClientFactoryInterface::class . '" instead.');
 
-    $services->set('setono_gls_webservice.client', Client::class)
-        ->args([service('setono_gls_webservice.factory.soap_client')]);
+    $services->set(Client::class)
+        ->args([service(SoapClientFactory::class)]);
 
-    $services->alias(ClientInterface::class, 'setono_gls_webservice.client');
+    $services->alias(ClientInterface::class, Client::class);
+    $services->alias('setono_gls_webservice.client', ClientInterface::class)
+        ->deprecate('setono/gls-webservice-bundle', '1.4', 'The "%alias_id%" service alias is deprecated. Use "' . ClientInterface::class . '" instead.');
 };