Improve IndexCommand output: resolved uids, summary, honest --delete warning#163
Open
loevgaard wants to merge 1 commit into
Open
Improve IndexCommand output: resolved uids, summary, honest --delete warning#163loevgaard wants to merge 1 commit into
loevgaard wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue-129-search-route-disabled #163 +/- ##
=====================================================================
+ Coverage 47.14% 48.55% +1.40%
- Complexity 777 781 +4
=====================================================================
Files 139 139
Lines 2503 2521 +18
=====================================================================
+ Hits 1180 1224 +44
+ Misses 1323 1297 -26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2f5f495 to
66d13e3
Compare
8ce7ef7 to
12dcb37
Compare
66d13e3 to
bb00e15
Compare
12dcb37 to
aba7b03
Compare
bb00e15 to
a110a78
Compare
aba7b03 to
52cfbb7
Compare
…warning - Print the resolved index uids per index up front (Indexing products → products__fashion_web__en_us__usd, …) so the operator can see exactly which Meilisearch indexes are being written. - Reword the --delete warning to state the consequence explicitly: the live index is deleted first, so search returns no results for that index until reindexing completes; a plain reindex upserts in place. - After --wait (when the Meilisearch tasks have finished), print a summary table of document count per resolved uid. The per-batch mapped/filtered/ invalid/indexed counts are emitted to the log by the indexer (#128). Closes #131
52cfbb7 to
f569bbb
Compare
a110a78 to
3b74c19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
setono:sylius-meilisearch:indexprinted onlyIndex "%s" submitted for indexing. Now:Indexing products → products__fashion_web__en_us__usd, …. In the default (synchronous) setup this also makes clear the command is doing real work, not hanging.--deletewarning. Reworded to state the consequence explicitly: the live index is deleted first, so search returns no results for that index until reindexing completes; a plain reindex (without--delete) upserts in place and avoids the downtime.--wait. Once the Meilisearch tasks have finished (which is why it's printed after--wait), a table of document count per resolved uid is shown.The per-batch mapped/filtered/invalid/indexed counts are emitted to the dedicated log channel by the indexer (#128) — those can't be aggregated back into the command process for an async run, so the command's summary reports the resulting document counts instead.
Testing
IndexCommandTest::it_prints_the_resolved_uids_and_an_honest_delete_warning(viaCommandTester): output names each resolved uid and the--deletewarning explains the downtime.createTasksQuerytests still pass.Closes #131
Stacked on #162 (#129).