Fix Acoustic Space Import Tool bug

Fixed bug causing low frequency responses imported using ‘Low frequency mode’ in the acoustic space import tool to fail to load

Author: ShanonPearce

ash_toolset/__main__.py

@@ -2057,7 +2057,7 @@ def get_screen_size(default_width=1722, default_height=717):
                                         dpg.add_checkbox(label="Enable", tag="as_subwoofer_mode",default_value=loaded_values["as_subwoofer_mode"])
                                         with dpg.tooltip("as_subwoofer_mode"):
                                             dpg.add_text("Enable to treat the IRs as low-frequency responses")
-                                            dpg.add_text("The result will appear under low-frequency extension options")
+                                            dpg.add_text("The result will appear under low-frequency extension options instead of acoustic space options")
 
                                     # ---------- Binaural Measurements ----------
                                     with dpg.table_row():

ash_toolset/air_processing.py

@@ -1166,16 +1166,17 @@ def convert_airs_to_brirs(
 
 
         #set number of output directions (brir sources) 
-        if auto_shape_output:#derive based on number of measurements
-            if subwoofer_mode == True:#only 1 set required if subwoofer response
-                num_brir_sources=1
-            elif total_measurements < CN.IR_MIN_THRESHOLD_FULLSET:#limited number of measurements
-                num_brir_sources = max(2, total_measurements // 250)#calculate one source per 250 measurements
-            else:
-                num_brir_sources = max(2, total_measurements // 360)#calculate one source per 360 measurements
-            
-        else:#manual shape mode -> use when called by AS import tool
-            num_brir_sources = virtual_speakers
+        if subwoofer_mode == True:#only 1 set required if subwoofer response
+            num_brir_sources=1
+        else:
+            if auto_shape_output:#derive based on number of measurements
+                if total_measurements < CN.IR_MIN_THRESHOLD_FULLSET:#limited number of measurements
+                    num_brir_sources = max(2, total_measurements // 250)#calculate one source per 250 measurements
+                else:
+                    num_brir_sources = max(2, total_measurements // 360)#calculate one source per 360 measurements
+                
+            else:#manual shape mode -> use when called by AS import tool
+                num_brir_sources = virtual_speakers
 
         log_string_a = 'num_brir_sources: ' + str(num_brir_sources)
         hf.log_with_timestamp(log_string_a)

ash_toolset/brir_generation.py

@@ -190,7 +190,7 @@ def generate_integrated_brir(brir_name,  spatial_res=1, report_progress=0, gui_l
         if sub_folder == 'sub' or sub_folder == 'lf_brir':#default sub responses
             npy_fname = pjoin(CN.DATA_DIR_SUB, sub_file_name+'.npy')
         else:#user sub response
-            file_folder = pjoin(CN.DATA_DIR_AS_USER,sub_response)
+            file_folder = pjoin(CN.DATA_DIR_AS_USER, sub_response.replace(" ", "_") )
             npy_fname = pjoin(file_folder, sub_file_name+'.npy')
         sub_brir_npy = hf.load_convert_npy_to_float64(npy_fname)
         sub_brir_ir = np.zeros((2,n_fft))

ash_toolset/callbacks.py

@@ -2105,7 +2105,7 @@ def plot_sub_brir(name, plot_dest,plot_type):
         if sub_folder in ('sub', 'lf_brir'):  # default sub responses
             npy_fname = pjoin(CN.DATA_DIR_SUB, sub_file_name + '.npy')
         else:  # user-provided sub response
-            file_folder = pjoin(CN.DATA_DIR_AS_USER, name)
+            file_folder = pjoin(CN.DATA_DIR_AS_USER, name.replace(" ", "_"))
             npy_fname = pjoin(file_folder, sub_file_name + '.npy')
 
         sub_brir_npy = hf.load_convert_npy_to_float64(npy_fname)

metadata.json

@@ -1 +1 @@
-{"version": "4.2.1","author":"Shanon Pearce"}
+{"version": "4.2.2","author":"Shanon Pearce"}