Fix nullable schema generation for non-required dictionary fields#100
Open
RobertIndie wants to merge 2 commits into
Open
Fix nullable schema generation for non-required dictionary fields#100RobertIndie wants to merge 2 commits into
RobertIndie wants to merge 2 commits into
Conversation
## Summary
- Make non-`[Required]` `Dictionary<TKey, TValue>` fields generate nullable Avro union schemas.
- Keep `[Required]` dictionary fields non-nullable.
## Details
Non-required dictionary fields now generate:
```json
"type": [
{ "type": "map", "values": "string" },
"null"
],
"default": {}
```
Required dictionary fields still generate:
```json
"type": { "type": "map", "values": "string" },
"default": {}
```
Contributor
Author
|
@eaba Could you help review this PR? Thanks! |
Member
|
I will resume work soon - months or years 🥰🥰 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
eaba
approved these changes
May 16, 2026
Member
Contributor
Author
|
HI @eaba Could you help merge this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, fields of type
Dictionaryare generated as non-nullable Avro map schemas, for example:{ "name": "MyMap", "type": { "type": "map", "values": "string" }, "default": {} }This causes serialization to fail when an optional dictionary field is unset, because the generated schema does not allow
nullvalues:Modifications
[Required]Dictionary<TKey, TValue>fields generate nullable Avro union schemas.[Required]dictionary fields non-nullable.Non-required dictionary fields now generate:
Required dictionary fields still generate: