ci: fix downstream integration - add submodules:recursive and pre-install metallib before build#4
Closed
ci: fix downstream integration - add submodules:recursive and pre-install metallib before build#4
Conversation
* update for mlx 0.31.1 - clean up some build settings (c++ version, warnings) - set mlx version (see ml-explore#370 and ml-explore#373)
- fixes xcode 26.4 build issue - fixes ml-explore#375
* Implement L2 normalization extension for MLXArray Adds an extension method to MLXArray for L2 normalization.
- fix ml-explore#378 - save functions call eval internally and must be run under evalLock
* Add doc comment verification script and CI step * Fix doc comments * Discover doc verification targets dynamically and report all failures
…xplore#384) QuantizedLinear.init(weight:...) called MLX.quantized() without forwarding the mode parameter, so weights were always quantized as affine regardless of the specified mode. This produced spurious biases for non-affine modes like mxfp4. Fix: pass mode: mode to MLX.quantized(), matching QuantizedEmbedding which already does this correctly. Note: no updateMissing() override is needed — when biases is nil, Module.build(value:) wraps it as .value(.other(...)), and the (.value(.other(_)), .none) case in update() already breaks silently. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ml-explore#394) - this should cover _most_ cases - there is still ([MLXArray]) -> [MLXArray] as a fallback
* add missing functions - eig - eigenvalues and eigenvectors - eigh - eigenvalues/eigenvectors of symmetric/Hermitian matrix - eigvals - eigenvalues only - eigvalsh - eigenvalues of symmetric/Hermitian matrix - pinv - pseudo-inverse * add remaining functions: - logcumsumexp - segmentedMm (segmented_mm) - permutation - fftshift - ifftshift
…tall metallib before build
Member
Author
|
Consolidated into PR #3 (sync/upstream-latest) — all fixes applied directly to that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues in
downstream_integration.yml:submodules: recursiveto SwiftLM checkout somlx-swift-lm/Package.swiftis initializedMLX_METAL_LIBenv var) so the server process finds it at runtime