Set SyncCommand to their real value

Author: wherewhere

AdvancedSharpAdbClient.Tests/Extensions/SyncCommandConverterTests.cs

@@ -16,14 +16,6 @@ public void GetCommandNullTest() =>
         public void GetCommandInvalidNumberOfBytesTest() =>
             _ = Assert.Throws<ArgumentOutOfRangeException>(() => SyncCommandConverter.GetCommand([]));
 
-        [Fact]
-        public void GetCommandInvalidCommandTest() =>
-            _ = Assert.Throws<ArgumentOutOfRangeException>(() => SyncCommandConverter.GetCommand("QMTV"u8));
-
-        [Fact]
-        public void GetBytesInvalidCommandTest() =>
-            _ = Assert.Throws<ArgumentOutOfRangeException>(() => ((SyncCommand)99).GetBytes());
-
         [Fact]
         public void SyncCommandConverterTest()
         {

AdvancedSharpAdbClient/Extensions/SyncCommandConverter.cs

@@ -22,23 +22,7 @@ public static class SyncCommandConverter
             /// Gets the byte array that represents the <see cref="SyncCommand"/>.
             /// </summary>
             /// <returns>A byte array that represents the <see cref="SyncCommand"/>.</returns>
-            public byte[] GetBytes()
-            {
-                if (command == 0)
-                {
-                    return [0, 0, 0, 0];
-                }
-
-                if (command is < SyncCommand.STAT or > SyncCommand.DNT2)
-                {
-                    throw new ArgumentOutOfRangeException(nameof(command), $"{command} is not a valid sync command");
-                }
-
-                string commandText = command.ToString();
-                byte[] commandBytes = AdbClient.Encoding.GetBytes(commandText);
-
-                return commandBytes;
-            }
+            public byte[] GetBytes() => BitConverter.GetBytes((int)command);
 
             /// <summary>
             /// Returns an enumerator that iterates through the <see cref="GetBytes(SyncCommand)"/>.
@@ -60,8 +44,7 @@ public static SyncCommand GetCommand(byte[] value)
                     throw new ArgumentOutOfRangeException(nameof(value));
                 }
 
-                string commandText = AdbClient.Encoding.GetString(value);
-                return commandText == "\0\0\0\0" ? 0 : Enum.TryParse(commandText, true, out SyncCommand result) ? result : throw new ArgumentOutOfRangeException(nameof(value), $"{commandText} is not a valid sync command");
+                return (SyncCommand)BitConverter.ToInt32(value);
             }
 
 #if HAS_BUFFERS
@@ -77,8 +60,7 @@ public static SyncCommand GetCommand(ReadOnlySpan<byte> value)
                     throw new ArgumentOutOfRangeException(nameof(value));
                 }
 
-                string commandText = AdbClient.Encoding.GetString(value);
-                return commandText == "\0\0\0\0" ? 0 : Enum.TryParse(commandText, true, out SyncCommand result) ? result : throw new ArgumentOutOfRangeException(nameof(value), $"{commandText} is not a valid sync command");
+                return (SyncCommand)BitConverter.ToInt32(value);
             }
 #endif
         }

AdvancedSharpAdbClient/Models/Enums/SyncCommand.cs

@@ -12,84 +12,84 @@ public enum SyncCommand
         /// <summary>
         /// Stat a file.
         /// </summary>
-        STAT = 1,
+        STAT = 'S' | ('T' << 8) | ('A' << 16) | ('T' << 24),
 
         /// <summary>
-        /// List the files in a folder.
+        /// Stat a file v2.
         /// </summary>
-        LIST,
+        /// <remarks>Need Android 8 or above.</remarks>
+        STA2 = 'S' | ('T' << 8) | ('A' << 16) | ('2' << 24),
 
         /// <summary>
-        /// Send a file to device.
+        /// Stat a list v2.
         /// </summary>
-        SEND,
+        /// <remarks>Need Android 8 or above.</remarks>
+        LST2 = 'L' | ('S' << 8) | ('T' << 16) | ('2' << 24),
 
         /// <summary>
-        /// Retrieve a file from device.
+        /// List the files in a folder.
         /// </summary>
-        RECV,
+        LIST = 'L' | ('I' << 8) | ('S' << 16) | ('T' << 24),
 
         /// <summary>
-        /// A directory entry.
+        /// List the files in a folder v2.
         /// </summary>
-        DENT,
+        /// <remarks>Need Android 11 or above.</remarks>
+        LIS2 = 'L' | ('I' << 8) | ('S' << 16) | ('2' << 24),
 
         /// <summary>
-        /// The operation has completed.
+        /// A directory entry.
         /// </summary>
-        DONE,
+        DENT = 'D' | ('E' << 8) | ('N' << 16) | ('T' << 24),
 
         /// <summary>
-        /// Marks the start of a data packet.
+        /// A directory entry v2.
         /// </summary>
-        DATA,
+        DNT2 = 'D' | ('N' << 8) | ('T' << 16) | ('2' << 24),
 
         /// <summary>
-        /// The server has acknowledged the request.
+        /// Send a file to device.
         /// </summary>
-        OKAY,
+        SEND = 'S' | ('E' << 8) | ('N' << 16) | ('D' << 24),
 
         /// <summary>
-        /// The operation has failed.
+        /// Retrieve a file from device v2.
         /// </summary>
-        FAIL,
+        SND2 = 'S' | ('N' << 8) | ('D' << 16) | ('2' << 24),
 
         /// <summary>
-        /// The server has acknowledged the request.
+        /// Retrieve a file from device.
         /// </summary>
-        QUIT,
+        RECV = 'R' | ('E' << 8) | ('C' << 16) | ('V' << 24),
 
         /// <summary>
-        /// Stat a file v2.
+        /// Retrieve a file from device v2.
         /// </summary>
-        /// <remarks>Need Android 8 or above.</remarks>
-        STA2,
+        RCV2 = 'R' | ('C' << 8) | ('V' << 16) | ('2' << 24),
 
         /// <summary>
-        /// Stat a list v2.
+        /// The operation has completed.
         /// </summary>
-        /// <remarks>Need Android 8 or above.</remarks>
-        LST2,
+        DONE = 'D' | ('O' << 8) | ('N' << 16) | ('E' << 24),
 
         /// <summary>
-        /// List the files in a folder v2.
+        /// Marks the start of a data packet.
         /// </summary>
-        /// <remarks>Need Android 11 or above.</remarks>
-        LIS2,
+        DATA = 'D' | ('A' << 8) | ('T' << 16) | ('A' << 24),
 
         /// <summary>
-        /// Retrieve a file from device v2.
+        /// The server has acknowledged the request.
         /// </summary>
-        SND2,
+        OKAY = 'O' | ('K' << 8) | ('A' << 16) | ('Y' << 24),
 
         /// <summary>
-        /// Retrieve a file from device v2.
+        /// The operation has failed.
         /// </summary>
-        RCV2,
+        FAIL = 'F' | ('A' << 8) | ('I' << 16) | ('L' << 24),
 
         /// <summary>
-        /// A directory entry v2.
+        /// The server has acknowledged the request.
         /// </summary>
-        DNT2
+        QUIT = 'Q' | ('U' << 8) | ('I' << 16) | ('T' << 24)
     }
 }