Skip to content

Commit 2c52782

Browse files
committed
make examples consistent
- fix comments - if the player is not in a club or is in a club with <5 members it will not error
1 parent e74dcfb commit 2c52782

3 files changed

Lines changed: 23 additions & 11 deletions

File tree

examples/async.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import brawlstats
21
import asyncio
32

3+
import brawlstats
4+
45
# Do not post your token on a public github!
56
client = brawlstats.Client('token', is_async=True)
67

@@ -12,11 +13,15 @@ async def main():
1213
print(player.solo_victories) # use snake_case instead of camelCase
1314

1415
club = await player.get_club()
15-
print(club.tag)
16-
members = await club.get_members() # members sorted by trophies
17-
best_players = members[:5] # gets best 5 players
18-
for player in best_players:
19-
print(player.name, player.trophies)
16+
if club is not None: # check if the player is in a club
17+
print(club.tag)
18+
members = await club.get_members() # members sorted by trophies
19+
20+
# gets best 5 players or returns all members if the club has less than 5 members
21+
index = max(5, len(members))
22+
best_players = members[:index]
23+
for player in best_players:
24+
print(player.name, player.trophies) # prints name and trophies
2025

2126
# get top 5 players in the world
2227
ranking = await client.get_rankings(ranking='players', limit=5)
@@ -33,6 +38,7 @@ async def main():
3338
for player in ranking:
3439
print(player.name, player.rank)
3540

41+
# Gets a player's recent battles
3642
battles = await client.get_battle_logs('GGJVJLU2')
3743
print(battles[0].battle.mode)
3844

examples/discord_cog.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import discord
22
from discord.ext import commands
3+
34
import brawlstats
45

56

examples/sync.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,15 @@
99
print(player.solo_victories) # use snake_case instead of camelCase
1010

1111
club = player.get_club()
12-
print(club.tag)
13-
members = club.get_members() # members sorted by trophies
14-
best_players = members[:5] # gets best 5 players
15-
for player in best_players:
16-
print(player.name, player.trophies) # prints name and trophies
12+
if club is not None: # check if the player is in a club
13+
print(club.tag)
14+
members = club.get_members() # members sorted by trophies
15+
16+
# gets best 5 players or returns all members if the club has less than 5 members
17+
index = max(5, len(members))
18+
best_players = members[:index]
19+
for player in best_players:
20+
print(player.name, player.trophies) # prints name and trophies
1721

1822
# gets top 5 players in the world
1923
ranking = client.get_rankings(ranking='players', limit=5)
@@ -30,5 +34,6 @@
3034
for player in ranking:
3135
print(player.name, player.rank)
3236

37+
# Gets a player's recent battles
3338
battles = client.get_battle_logs('GGJVJLU2')
3439
print(battles[0].battle.mode)

0 commit comments

Comments
 (0)