fix brawler id data gotten, only modify the passed in brawler if it is a str

Author: SharpBit

brawlstats/brawlapi/utils.py

@@ -39,7 +39,7 @@ def __init__(self, base_url, version=1):
             self.BRAWLERS = {}
         else:
             if data:
-                self.BRAWLERS = {b['tID'].lower(): b['scId'] for b in data['characters'] if b['tID']}
+                self.BRAWLERS = {b['tID'].lower(): str(b['scId'])[:2] + '0' + str(b['scId'])[2:] for b in data['characters'] if b['tID']}
             else:
                 self.BRAWLERS = {}
 

brawlstats/constants.json

@@ -254,7 +254,7 @@ def get_rankings(self, ranking_type: str, limit: int=200, region='global', brawl
 
         Returns Ranking
         """
-        if brawler:
+        if type(brawler) == str:
             brawler = brawler.lower()
         if brawler not in self.api.BRAWLERS and ranking_type not in ['players', 'clubs', 'brawlers']:
             raise ValueError("Please enter 'players', 'clubs' or a brawler.")

brawlstats/officialapi/core.py

@@ -27,7 +27,7 @@ def __init__(self, base_url, version=1):
             self.BRAWLERS = {}
         else:
             if data:
-                self.BRAWLERS = {b['tID'].lower(): b['scId'] for b in data['characters'] if b['tID']}
+                self.BRAWLERS = {b['tID'].lower(): str(b['scId'])[:2] + '0' + str(b['scId'])[2:] for b in data['characters'] if b['tID']}
             else:
                 self.BRAWLERS = {}
 

brawlstats/officialapi/utils.py

@@ -53,6 +53,8 @@ def test_get_rankings_club(self):
     def test_get_rankings_brawler(self):
         lb = self.client.get_rankings('brawlers', brawler='shelly')
         self.assertTrue(isinstance(lb, brawlstats.officialapi.Ranking))
+        rankings = self.client.get_rankings('brawlers', brawler=16000000)
+        self.assertTrue(isinstance(rankings, brawlstats.officialapi.Ranking))
 
     def test_get_constants(self):
         default = self.client.get_constants()