Optimize job logs and reset startup log

Author: mkn8rn

.github/workflows/ci.yml

@@ -133,7 +133,7 @@ jobs:
           - domain: Chat Streaming
             filter: 'FullyQualifiedName~TestHarnessStreamingCorrectnessTests'
           - domain: Jobs Direct
-            filter: 'FullyQualifiedName~DirectJobSubmissionCompletes|FullyQualifiedName~DirectJobDeniedStops|FullyQualifiedName~DirectJobAwaitingApproval|FullyQualifiedName~DirectJobApprovalDenies|FullyQualifiedName~DirectJobFailure'
+            filter: 'FullyQualifiedName~DirectJobSubmissionCompletes|FullyQualifiedName~DirectJobDetailAndLifecycleActionsReuseCachedLogs|FullyQualifiedName~DirectJobDeniedStops|FullyQualifiedName~DirectJobAwaitingApproval|FullyQualifiedName~DirectJobApprovalDenies|FullyQualifiedName~DirectJobFailure'
           - domain: Jobs Lifecycle
             filter: 'FullyQualifiedName~LongRunningDirectJobPauseResumeStopAndCompletedCancelAreStable'
           - domain: Jobs Streaming
@@ -169,7 +169,7 @@ jobs:
           - domain: Defaults Resource Resolution
             filter: 'FullyQualifiedName~PerResourceJob'
           - domain: Module API Host Startup
-            filter: 'FullyQualifiedName~SharpClaw.Tests.Modules.ApiHostStartupTests'
+            filter: 'FullyQualifiedName~SharpClaw.Tests.Modules.ApiHostStartupTests|FullyQualifiedName~SharpClaw.Tests.Logging.SessionLogWriterTests'
           - domain: Module Bundled Outputs
             filter: 'FullyQualifiedName~SharpClaw.Tests.Modules.BundledModuleOutputTests'
           - domain: Module External Lifecycle
@@ -229,7 +229,7 @@ jobs:
           - domain: Jobs Direct Actions
             filter: 'FullyQualifiedName~PerformanceGate_DirectJobAllowedWarmNoOp|FullyQualifiedName~PerformanceGate_DirectJobDeniedWarmNoOp'
           - domain: Jobs Summaries
-            filter: 'FullyQualifiedName~PerformanceGate_DirectJobSummaries'
+            filter: 'FullyQualifiedName~PerformanceGate_DirectJobSummaries|FullyQualifiedName~PerformanceGate_DirectJobDetailHotLogs'
           - domain: Jobs Parallel
             filter: 'FullyQualifiedName~PerformanceGate_DirectJob_TwentyParallelAllowedNoOpJobs'
           - domain: Tools Permission Checks

SharpClaw.Application.API/Handlers/AgentJobHandlers.cs

@@ -39,7 +39,7 @@ public static async Task<IResult> GetById(
     public static async Task<IResult> Approve(
         Guid channelId, Guid jobId, ApproveAgentJobRequest request, AgentJobService svc, ChatService chatSvc)
     {
-        if (await GetScopedJobAsync(channelId, jobId, svc) is null) return Results.NotFound();
+        if (await GetScopedJobSummaryAsync(channelId, jobId, svc) is null) return Results.NotFound();
         var job = await svc.ApproveAsync(jobId, request);
         if (job is null) return Results.NotFound();
         var cost = await chatSvc.GetChannelCostAsync(job.ChannelId);
@@ -50,7 +50,7 @@ public static async Task<IResult> Approve(
     public static async Task<IResult> Stop(
         Guid channelId, Guid jobId, AgentJobService svc, ChatService chatSvc)
     {
-        if (await GetScopedJobAsync(channelId, jobId, svc) is null) return Results.NotFound();
+        if (await GetScopedJobSummaryAsync(channelId, jobId, svc) is null) return Results.NotFound();
         var job = await svc.StopAsync(jobId);
         if (job is null) return Results.NotFound();
         var cost = await chatSvc.GetChannelCostAsync(job.ChannelId);
@@ -61,7 +61,7 @@ public static async Task<IResult> Stop(
     public static async Task<IResult> Cancel(
         Guid channelId, Guid jobId, AgentJobService svc, ChatService chatSvc)
     {
-        if (await GetScopedJobAsync(channelId, jobId, svc) is null) return Results.NotFound();
+        if (await GetScopedJobSummaryAsync(channelId, jobId, svc) is null) return Results.NotFound();
         var job = await svc.CancelAsync(jobId);
         if (job is null) return Results.NotFound();
         var cost = await chatSvc.GetChannelCostAsync(job.ChannelId);
@@ -72,7 +72,7 @@ public static async Task<IResult> Cancel(
     public static async Task<IResult> Pause(
         Guid channelId, Guid jobId, AgentJobService svc, ChatService chatSvc)
     {
-        if (await GetScopedJobAsync(channelId, jobId, svc) is null) return Results.NotFound();
+        if (await GetScopedJobSummaryAsync(channelId, jobId, svc) is null) return Results.NotFound();
         var job = await svc.PauseAsync(jobId);
         if (job is null) return Results.NotFound();
         var cost = await chatSvc.GetChannelCostAsync(job.ChannelId);
@@ -83,7 +83,7 @@ public static async Task<IResult> Pause(
     public static async Task<IResult> Resume(
         Guid channelId, Guid jobId, AgentJobService svc, ChatService chatSvc)
     {
-        if (await GetScopedJobAsync(channelId, jobId, svc) is null) return Results.NotFound();
+        if (await GetScopedJobSummaryAsync(channelId, jobId, svc) is null) return Results.NotFound();
         var job = await svc.ResumeAsync(jobId);
         if (job is null) return Results.NotFound();
         var cost = await chatSvc.GetChannelCostAsync(job.ChannelId);
@@ -96,4 +96,11 @@ public static async Task<IResult> Resume(
         var job = await svc.GetAsync(jobId);
         return job?.ChannelId == channelId ? job : null;
     }
+
+    private static async Task<AgentJobSummaryResponse?> GetScopedJobSummaryAsync(
+        Guid channelId, Guid jobId, AgentJobService svc)
+    {
+        var job = await svc.GetSummaryAsync(jobId);
+        return job?.ChannelId == channelId ? job : null;
+    }
 }

SharpClaw.Application.Core/Modules/HostAgentJobController.cs

@@ -10,7 +10,8 @@ namespace SharpClaw.Application.Core.Modules;
 
 public sealed class HostAgentJobController(
     AgentJobService jobs,
-    SharpClawDbContext db) : IAgentJobController
+    SharpClawDbContext db,
+    ChatCache chatCache) : IAgentJobController
 {
     public Task<AgentJobResponse> SubmitJobAsync(
         Guid channelId,
@@ -33,14 +34,16 @@ public async Task AddJobLogAsync(
         var job = await db.AgentJobs.FirstOrDefaultAsync(j => j.Id == jobId, ct);
         if (job is null) return;
 
-        job.LogEntries.Add(new AgentJobLogEntryDB
+        var entry = new AgentJobLogEntryDB
         {
             AgentJobId = jobId,
             Message = message,
             Level = level,
-        });
+        };
+        job.LogEntries.Add(entry);
 
         await db.SaveChangesAsync(ct);
+        chatCache.AppendJobLogIfCached(jobId, ToLogResponse(entry));
     }
 
     public async Task MarkJobFailedAsync(
@@ -55,14 +58,16 @@ public async Task MarkJobFailedAsync(
         job.Status = AgentJobStatus.Failed;
         job.CompletedAt = DateTimeOffset.UtcNow;
         job.ErrorLog = exception.ToString();
-        job.LogEntries.Add(new AgentJobLogEntryDB
+        var entry = new AgentJobLogEntryDB
         {
             AgentJobId = jobId,
             Message = $"Job failed: {exception.Message}",
             Level = JobLogLevels.Error,
-        });
+        };
+        job.LogEntries.Add(entry);
 
         await db.SaveChangesAsync(ct);
+        chatCache.AppendJobLogIfCached(jobId, ToLogResponse(entry));
     }
 
     public async Task MarkJobCompletedAsync(
@@ -80,16 +85,18 @@ public async Task MarkJobCompletedAsync(
         if (resultData is not null)
             job.ResultData = resultData;
 
-        job.LogEntries.Add(new AgentJobLogEntryDB
+        var entry = new AgentJobLogEntryDB
         {
             AgentJobId = jobId,
             Message = string.IsNullOrWhiteSpace(message)
                 ? "Job completed by module."
                 : message,
             Level = JobLogLevels.Info,
-        });
+        };
+        job.LogEntries.Add(entry);
 
         await db.SaveChangesAsync(ct);
+        chatCache.AppendJobLogIfCached(jobId, ToLogResponse(entry));
     }
 
     public async Task MarkJobCancelledAsync(
@@ -103,16 +110,18 @@ public async Task MarkJobCancelledAsync(
 
         job.Status = AgentJobStatus.Cancelled;
         job.CompletedAt = DateTimeOffset.UtcNow;
-        job.LogEntries.Add(new AgentJobLogEntryDB
+        var entry = new AgentJobLogEntryDB
         {
             AgentJobId = jobId,
             Message = string.IsNullOrWhiteSpace(message)
                 ? "Job cancelled by module."
                 : message,
             Level = JobLogLevels.Warning,
-        });
+        };
+        job.LogEntries.Add(entry);
 
         await db.SaveChangesAsync(ct);
+        chatCache.AppendJobLogIfCached(jobId, ToLogResponse(entry));
     }
 
     public async Task CancelStaleJobsByActionPrefixAsync(
@@ -131,19 +140,29 @@ public async Task CancelStaleJobsByActionPrefixAsync(
             .Where(j => j.ActionKey!.StartsWith(actionKeyPrefix, StringComparison.OrdinalIgnoreCase))
             .ToList();
 
+        var cancelledLogs = new List<(Guid JobId, AgentJobLogEntryDB Entry)>(stale.Count);
         foreach (var job in stale)
         {
             job.Status = AgentJobStatus.Cancelled;
             job.CompletedAt = DateTimeOffset.UtcNow;
-            job.LogEntries.Add(new AgentJobLogEntryDB
+            var entry = new AgentJobLogEntryDB
             {
                 AgentJobId = job.Id,
                 Message = "Cancelled: stale from previous session.",
                 Level = JobLogLevels.Warning,
-            });
+            };
+            job.LogEntries.Add(entry);
+            cancelledLogs.Add((job.Id, entry));
         }
 
         if (stale.Count > 0)
+        {
             await db.SaveChangesAsync(ct);
+            foreach (var (jobId, entry) in cancelledLogs)
+                chatCache.AppendJobLogIfCached(jobId, ToLogResponse(entry));
+        }
     }
+
+    private static AgentJobLogResponse ToLogResponse(AgentJobLogEntryDB log)
+        => new(log.Message, log.Level, log.CreatedAt);
 }