fix: rollback on health check fail

Author: Shawiizz

cli/src/commands/deploy-phases.ts

@@ -372,16 +372,19 @@ export async function deployApp(ctx: DeployContext, compose: ParsedCompose): Pro
       );
     }
 
-    if (ctx.config.health_checks?.endpoints?.length) {
-      await health.checkHTTPEndpoints(ctx.config.health_checks);
-    }
   }
 
   await Nginx.deployNginxTemplates(ctx.cluster.manager.connection, ctx.rendered);
 
   await Hook.runRemote('post-deploy', ctx.cluster.manager.connection, ctx.stackName, ctx.projectRoot, ctx.config, ctx.rendered);
 }
 
+export async function runHTTPHealthChecks(ctx: DeployContext): Promise<void> {
+  if (!ctx.deployApp || !ctx.config.health_checks?.endpoints?.length) return;
+  const health = new HealthCheck(ctx.cluster.manager.connection, ctx.orchestrator);
+  await health.checkHTTPEndpoints(ctx.config.health_checks);
+}
+
 // ---------------------------------------------------------------------------
 // Phase: Audit, metrics, history sync (best-effort)
 // ---------------------------------------------------------------------------

cli/src/commands/deploy.ts

@@ -57,7 +57,7 @@ import { Metrics } from '../services/metrics';
 import * as Notification from '../services/notification';
 
 import type { DeployOptions, DeployContext } from './deploy-context';
-import { buildAndDistribute, uploadFiles, rollbackUploads, commitUploads, deployAccessories, deployApp, recordHistory } from './deploy-phases';
+import { buildAndDistribute, uploadFiles, rollbackUploads, commitUploads, deployAccessories, deployApp, runHTTPHealthChecks, recordHistory } from './deploy-phases';
 import type { UploadRollbackPlan } from './deploy-phases';
 
 // ---------------------------------------------------------------------------
@@ -305,6 +305,8 @@ async function execute(ctx: DeployContext): Promise<void> {
     await deployApp(ctx, compose);
     stackDeployed = ctx.deployApp !== false;
 
+    await runHTTPHealthChecks(ctx);
+
     await Promise.all([
       ctx.releases.cleanupOldReleases(ctx.stackName, ctx.config),
       commitUploads(uploadPlan).catch((e) => printWarning(`Upload commit failed: ${e instanceof Error ? e.message : String(e)}`)),