fix(sync): treat repo_state_sync as derived state; allow clean repo bootstrap

Author: Dee66

src/shieldcraft/services/sync/__init__.py

@@ -162,9 +162,21 @@ def verify_repo_state_authoritative(repo_root: str = ".") -> Dict[str, str]:
 
     # 'repo_state_sync' mode: verify external repo_state_sync.json and associated artifacts
     if authority == "repo_state_sync":
-        res = verify_repo_sync(repo_root)
-        res["authority"] = "repo_state_sync"
-        return res
+        # Treat repo_state_sync as derived state (non-mandatory):
+        # If the external sync artifact is present, validate it; if it is
+        # missing, allow the run to proceed (do not raise SyncError).
+        try:
+            res = verify_repo_sync(repo_root)
+            res["authority"] = "repo_state_sync"
+            return res
+        except Exception as e:
+            # If it's a SyncError due to missing artifact, relax and proceed;
+            # otherwise re-raise to preserve strict failure modes for other errors.
+            from inspect import getmodule
+            # Detect SyncError by attribute presence (class imported above)
+            if getattr(e, "code", None) == SYNC_MISSING:
+                return {"ok": True, "authority": "repo_state_sync", "artifact": None}
+            raise
 
     # Snapshot-based authority (opt-in only)
     from shieldcraft.snapshot import validate_snapshot, generate_snapshot, DEFAULT_SNAPSHOT_PATH, SnapshotError

tests/ci/test_v1_invariants.py

@@ -3,15 +3,14 @@
 
 
 def test_snapshot_authority_is_default(monkeypatch, tmp_path):
-    from shieldcraft.services.sync import verify_repo_state_authoritative, SyncError
+    from shieldcraft.services.sync import verify_repo_state_authoritative
 
     # Unset any explicit authority and ensure repo_state_sync is used by default
     monkeypatch.delenv('SHIELDCRAFT_SYNC_AUTHORITY', raising=False)
     monkeypatch.delenv('SHIELDCRAFT_ALLOW_EXTERNAL_SYNC', raising=False)
 
-    # In a fresh tmp dir with no repo_state_sync artifact, default mode should raise SyncError
-    with pytest.raises(SyncError):
-        verify_repo_state_authoritative(str(tmp_path))
+    # In a fresh tmp dir with no repo_state_sync artifact, default mode should NOT raise
+    assert verify_repo_state_authoritative(str(tmp_path)).get("ok") is True
 
 
 def test_external_requires_explicit_opt_in(monkeypatch, tmp_path):